-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for relative step sizes #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
warnings.warn(f'point is zero valued in dimension {dimension},' | ||
f'resulting in zero step.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warnings.warn(f'point is zero valued in dimension {dimension},' | |
f'resulting in zero step.') | |
warnings.warn(f'point is zero valued in dimension {dimension}, ' | |
f'resulting in zero step.') |
I am wondering if this could be handled better. Provide a fall-back absolute step in case the step would be zero? Interpret the supposedly relative step as absolut? Fine as is for now.
@dilpath Which of the tests are expected to pass? I think the ones expected to fail should either xfail, or be moved to a separate pull request. |
Thanks for the various PRs @FFroehlich! Unfortunately, there is a redesign of this package (the I intend to incorporate the work done in your PRs into [1] https://github.com/ICB-DCM/fiddy/blob/redesign/examples/derivative.ipynb |
done in #20 |
No description provided.