UB-1622 provisioner long time for start in the installation phase

[27149chen]

helm install takes ~3.5 mins, while provisioner activation takes ~2 mins. The root cause is that the default timeout interval for a http request is very long. This PR:

1. set a short timeout for every request (10 seconds)
2. set a shorter timeout for activation (2 seconds) and retry 30 times if it fails.

---

This change is 

[coveralls]

Coverage decreased (-0.1%) to 58.662% when pulling 8f8a750 on feature/UB-1622_provisioner_timeout_during_installation into bf9a572 on dev.

[shay-berman]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @27149chen and @shay-berman)

---

remote/client.go, line 54 at r1 (raw file):

	clientWithShortTimeout := new(http.Client)
	*clientWithShortTimeout = *s.httpClient
	clientWithShortTimeout.Timeout = time.Second * 2

2 seconds sound to low. i think the default is 2 minutes, so maybe set it for 10 seconds. (and also consider to reduce the retires from 30 to 5)

---

remote/client_init.go, line 72 at r1 (raw file):

	s.storageApiURL = fmt.Sprintf(storageAPIURL, protocol, s.config.UbiquityServer.Address, s.config.UbiquityServer.Port)
	s.httpClient = &http.Client{
		Timeout: time.Second * 10,

since its a global change - make sure QA know about it and check if it breaks something.
If its the global one and the default is 2 minutes consider to set it to 30s instead of 120s.
up to you

[27149chen]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @shay-berman and @27149chen)

---

remote/client.go, line 54 at r1 (raw file):

Previously, shay-berman wrote…

2 seconds sound to low. i think the default is 2 minutes, so maybe set it for 10 seconds. (and also consider to reduce the retires from 30 to 5)

activation is a very fast action, take less then 1 second, so I think 2 second is enough. 2 * 30 = 60 while 10 * 5 = 50, so if I keep 2 seconds timeout, 30 times is reasonable, is it?

---

remote/client_init.go, line 72 at r1 (raw file):

Previously, shay-berman wrote…

since its a global change - make sure QA know about it and check if it breaks something.
If its the global one and the default is 2 minutes consider to set it to 30s instead of 120s.
up to you

ok, 30 is acceptable

[shay-berman]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @27149chen and @olgashtivelman)

---

remote/client.go, line 54 at r1 (raw file):

Previously, 27149chen wrote…

activation is a very fast action, take less then 1 second, so I think 2 second is enough. 2 * 30 = 60 while 10 * 5 = 50, so if I keep 2 seconds timeout, 30 times is reasonable, is it?

I still think that 2 seconds is low, what if you have low network for a while, in that case it will never succeed.
I would set it to 5~10 seconds.
please decide and update.

BTW make sure you run staging before merge to dev.

[27149chen]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @olgashtivelman and @shay-berman)

---

remote/client.go, line 54 at r1 (raw file):

Previously, shay-berman wrote…

I still think that 2 seconds is low, what if you have low network for a while, in that case it will never succeed.
I would set it to 5~10 seconds.
please decide and update.

BTW make sure you run staging before merge to dev.

ok, set to 5 seconds now, please approve this PR