This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Merge dev GA v1.0.0 to master branch #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohamed Mohamed <[email protected]>
Signed-off-by: Mohamed Mohamed <[email protected]>
Signed-off-by: Mohamed Mohamed <[email protected]>
#90: configurable database
Signed-off-by: Mohamed Mohamed <[email protected]>
#90: configurable database
#90: configurable database
Changed the image to point to artifactory Signed-off-by: Mohamed Mohamed <[email protected]>
#99: add credentials to all requests
…ment. add placeholder in the ubiquity IMAGE
#99: add credentials to all requests
#99: add credentials to all requests
Signed-off-by: Mohamed Mohamed <[email protected]>
Signed-off-by: Mohamed Mohamed <[email protected]>
Signed-off-by: Mohamed Mohamed <[email protected]>
#104: use TLS certificates in server
#104: use TLS certificates in plugin
Signed-off-by: Mohamed Mohamed <[email protected]>
Signed-off-by: Shay Berman <[email protected]>
Identify the mp device via sg_inq (wwn) in case the wwn not show up in the multipath -ll output
* Improve umount tolerance: umount should not fail if the device is already not mounted * Improve Cleanup multipath tolerance: Cleanup should not fail if mp device is not exist * change verify is mounted by using mount command instead of umount error msg (based Ran comment) * Updated the flow of umount to first try umount, only if err returns we try to see if it's already unmounted * Small info msg fix
…tipath -ll (#164) * Added validity check for wwn of found volume in discover. added unittests. * Validity checks - review issues.
#166) * Added a timeout for an execute call, and a timeout for sg_inq. + unittests * review issues * Replaced timeout with our own timeout * No sleep in timeout * Added more wait for async select function * Added return stmnt inside select channel * fix the command with timeout * Changed the waiting time.
…unmount flow) (#167) * Increase mpath and rescan lock from 100 to 500ms * Do NOT run discover during unmount(to reduce bad logging to find volume that was unmaped already) * Fix wrong debug message in rescanLock * Fix message from Debug to Error when discover doesn't find WWN in multipath -ll (usually the multipath WWN bad thing)
… ERROR as well. (with Alon)
…ginq_flow Align text in debug messages during sg_inq flow. Use Debug instead of…
* Legal : Add Apache LICENSE and NOTICES files into /root of the ubiquity image (Dockerfile)
…(Dockerfile) Note: assume the same LICENSE copied from repo/LICENSE inside the scripts/ubiquity-postgresql directory before docker build
Add Apache LICENSE and NOTICES files into / of the ubiquity-db image …
…only for IBM devices (PR #171) Improve performance for mpath Discovery method - no need to do deepDiscovery during Attachment. More details: 1. Do NOT do sg_inq deepDiscovery during the RescanAll in the attach flow. Its waist of time to do deepDiscovery in this case, since its already done after the RescanAll when discovering the new device. 2. Do sg_inq deepDiscovery only in the following cases: 1.2.1. During the attach after the RescanAll 1.2.2. When Discover for cleanup(unmount flow). 3. Remove double sg_inq validation if discover during deepDiscovery 4. Remove Stat(mpath) validation during Discover, since its already validated during GetWwnByScsiInq() or DiscoverBySgInq() 5. Fix interfaces, UT and fakes according (Still need to add more UT) In addition: This commit also improve the DiscoverBySgInq - by go though only IBM devices. So in many cases a faulty mpath device will not have vendor IBM on it, so it will skip faulty devices as well.
|
Review status: 0 of 84 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
|
Reviewed 84 of 84 files at r1. Comments from Reviewable |
|
Comments from Reviewable |
|
Reviewed 84 of 84 files at r1. Comments from Reviewable |
alonm
approved these changes
Dec 19, 2017
|
Reviewed 74 of 84 files at r1. Comments from Reviewable |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is