Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Define errno structure correctly #192

Merged
merged 1 commit into from
Mar 26, 2020
Merged

fix: Define errno structure correctly #192

merged 1 commit into from
Mar 26, 2020

Conversation

kadler
Copy link
Member

@kadler kadler commented Mar 26, 2020

The bytes available and bytes provided fields were flipped around, which
is easy to do when they are not given names so names were also added.

Fixes #191

The bytes available and bytes provided fields were flipped around, which
is easy to do when they are not given names so names were also added.

Fixes #191
@kadler kadler requested a review from abmusse March 26, 2020 18:32
Copy link
Member

@abmusse abmusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Good use of naming the parameters.

@kadler kadler merged commit b1561f7 into master Mar 26, 2020
@kadler kadler deleted the fix-errno branch March 26, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolkit.js errno value defined incorrectly
2 participants