fix: Move iConn compatibility code to iConn itself #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v1, iConn is now a wrapper around Connection, however the compatibility code was added to the Connection constructor instead of having iConn do that, which means that Connection still had the same signature as iConn and users could still use it the same way (though it was not going to be documented as such). Instead, iConn should handle its own compatibilty layer itself so that when the deprecated function is removed, the compatibility layer is removed as well and it prevents users from using Connection in a way that is not supported.
|
Thanks for catching and fixing this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v1, iConn is now a wrapper around Connection, however the
compatibility code was added to the Connection constructor instead of
having iConn do that, which means that Connection still had the same
signature as iConn and users could still use it the same way (though it
was not going to be documented as such). Instead, iConn should handle
its own compatibilty layer itself so that when the deprecated function
is removed, the compatibility layer is removed as well and it prevents
users from using Connection in a way that is not supported.
Fixes #221