Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move iConn compatibility code to iConn itself #221

Closed
abmusse opened this issue Apr 1, 2020 · 0 comments · Fixed by #218
Closed

Move iConn compatibility code to iConn itself #221

abmusse opened this issue Apr 1, 2020 · 0 comments · Fixed by #218
Labels
bug Something isn't working

Comments

@abmusse
Copy link
Member

abmusse commented Apr 1, 2020

In v1, iConn is now a wrapper around Connection, however the
compatibility code was added to the Connection constructor instead of
having iConn do that, which means that Connection still had the same
signature as iConn and users could still use it the same way (though it
was not going to be documented as such). Instead, iConn should handle
its own compatibilty layer itself so that when the deprecated function
is removed, the compatibility layer is removed as well and it prevents
users from using Connection in a way that is not supported.

Originally posted by @kadler in #218 (comment)

@abmusse abmusse added the bug Something isn't working label Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant