remove FORCE_TTY and FORCE_WATCH

Signed-off-by: Nick Mitchell <[email protected]>

pkg/boot/up.go

@@ -67,7 +67,7 @@ func upLLIR(ctx context.Context, backend be.Backend, ir llir.LLIR, opts UpOption
 	isRunning := make(chan struct{})
 	cancellable, cancel := context.WithCancel(ctx)
 
-	if opts.Watch && !util.StdoutIsTty() && os.Getenv("LUNCHPAIL_FORCE_WATCH") == "" {
+	if opts.Watch && !util.StdoutIsTty() {
 		// if stdout is not a tty, then we can't support
 		// watch, no matter what the user asked for
 		fmt.Fprintf(os.Stderr, "Warning: disabling watch mode because stdout is not a tty\n")

pkg/util/term.go

@@ -10,5 +10,5 @@ func StdinIsTty() bool {
 }
 
 func StdoutIsTty() bool {
-	return term.IsTerminal(int(os.Stdout.Fd())) || os.Getenv("LUNCHPAIL_FORCE_TTY") != ""
+	return term.IsTerminal(int(os.Stdout.Fd()))
 }

tests/bin/up.sh

@@ -9,12 +9,6 @@ if [[ -n "$taskqueue" ]]
 then QUEUE="--queue $taskqueue"
 fi
 
-# due to the use of eval, `up` will think it is not attached to a tty
-export LUNCHPAIL_FORCE_WATCH=1
-
-# same re: eval... the pipeline/redirect needs to know it is attached to a tty
-export LUNCHPAIL_FORCE_TTY=1
-
 echo "Calling up using target=${LUNCHPAIL_TARGET:-kubernetes}"
 eval $testapp up \
          -v \