-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging modules as single package with extra (data-prep-kit[ray,spark] and data-prep-kit-tranforms[all, ray, etc.]) #674
Closed
Closed
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
bedc179
added single package for data-prep-kit with extra[dev,ray,spak]
touma-I c6514d5
Crate a single package with [all,ray,code_quality,etc.]
touma-I 552b5fc
fix typos
touma-I 05b9c85
fix typo
touma-I 37454af
Added requirements.txt to dockerfile
touma-I 46ba795
added requirements.txt to context
touma-I d52701b
pip install python requirments from txt file
touma-I 8e77eb7
copy requiremwnts.txt if prsent
touma-I 4e62fb0
try to install requirements file directly.
touma-I 0ada456
Apply same fix as for python image. For some reason, in this image we…
touma-I 81fdd0f
prevent kfp-workflow from installing local requirements found in /tra…
touma-I 5bca3f9
Merge branch 'dev' into dev0-python12
touma-I df99886
change author name for pyproject.tml
touma-I 5b4572b
Update README.md
shahrokhDaijavad e641e49
Update quick-start.md
shahrokhDaijavad 0e7b710
Update README.md
shahrokhDaijavad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
[project] | ||
name = "data_prep_toolkit" | ||
version = "0.2.2.dev0" | ||
keywords = ["data", "data preprocessing", "data preparation", "llm", "generative", "ai", "fine-tuning", "llmapps" ] | ||
requires-python = ">=3.10" | ||
description = "Data Preparation Toolkit Library for Ray and Python" | ||
license = {text = "Apache-2.0"} | ||
readme = {file = "README.md", content-type = "text/markdown"} | ||
authors = [ | ||
{ name = "David Wood", email = "[email protected]" }, | ||
{ name = "Boris Lublinsky", email = "[email protected]" }, | ||
] | ||
|
||
dynamic = ["dependencies", "optional-dependencies"] | ||
|
||
[project_urls] | ||
Repository = "https://github.com/IBM/data-prep-kit" | ||
Issues = "https://github.com/IBM/data-prep-kit/issues" | ||
Documentation = "https://ibm.github.io/data-prep-kit/" | ||
"Transform project" = "https://github.com/IBM/data-prep-kit/tree/dev/transforms/universal/noop" | ||
|
||
[build-system] | ||
requires = ["setuptools>=68.0.0", "wheel", "setuptools_scm[toml]>=7.1.0"] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[tool.setuptools.dynamic.dependencies] | ||
file = ["requirements.txt"] | ||
|
||
[tool.setuptools.dynamic.optional-dependencies] | ||
dev = { file = ["requirements-dev.txt"]} | ||
ray = { file = ["requirements-ray.txt"]} | ||
spark = { file = ["requirements-spark.txt"]} | ||
|
||
[tool.setuptools.packages.find] | ||
where = ["python/src", "ray/src", "spark/src"] | ||
|
||
|
||
[tool.pytest.ini_options] | ||
# Currently we use low coverage since we have to run tests separately (see makefile) | ||
#addopts = "--cov --cov-report term-missing --cov-fail-under 25" | ||
markers = ["unit: unit tests", "integration: integration tests"] | ||
|
||
[tool.coverage.run] | ||
include = ["src/*"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
twine | ||
pytest>=7.3.2 | ||
pytest-dotenv>=0.5.2 | ||
pytest-env>=1.0.0 | ||
pre-commit>=3.3.2 | ||
pytest-cov>=4.1.0 | ||
pytest-mock>=3.10.0 | ||
moto==5.0.5 | ||
markupsafe==2.0.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
ray[default]==2.24.0 | ||
fastapi>=0.110.2 | ||
pillow>=10.3.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
pyspark>=3.5.2 | ||
psutil>=6.0.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
numpy < 1.29.0 | ||
pyarrow==16.1.0 | ||
boto3==1.34.69 | ||
argparse | ||
mmh3 | ||
psutil |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,16 +9,15 @@ authors = [ | |
{ name = "David Wood", email = "[email protected]" }, | ||
{ name = "Boris Lublinsky", email = "[email protected]" }, | ||
] | ||
dependencies = [ | ||
"data-prep-toolkit==0.2.2.dev0", | ||
"parameterized", | ||
"pandas", | ||
] | ||
dynamic = ["dependencies"] | ||
|
||
[build-system] | ||
requires = ["setuptools>=68.0.0", "wheel", "setuptools_scm[toml]>=7.1.0"] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[tool.setuptools.dynamic] | ||
dependencies = {file = ["requirements.txt"]} | ||
|
||
[project.optional-dependencies] | ||
dev = [ | ||
"twine", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
data-prep-toolkit==0.2.2.dev0 | ||
parameterized | ||
pandas |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,16 +8,16 @@ readme = {file = "README.md", content-type = "text/markdown"} | |
authors = [ | ||
{ name = "Shivdeep Singh", email = "[email protected]" }, | ||
] | ||
dependencies = [ | ||
"data-prep-toolkit==0.2.2.dev0", | ||
"bs4==0.0.2", | ||
"transformers==4.38.2", | ||
] | ||
dynamic = ["dependencies"] | ||
|
||
[build-system] | ||
requires = ["setuptools>=68.0.0", "wheel", "setuptools_scm[toml]>=7.1.0"] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[tool.setuptools.dynamic] | ||
dependencies = {file = ["requirements.txt"]} | ||
|
||
|
||
[project.optional-dependencies] | ||
dev = [ | ||
"twine", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
data-prep-toolkit==0.2.2.dev0 | ||
bs4==0.0.2 | ||
transformers==4.38.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,15 +8,16 @@ readme = {file = "README.md", content-type = "text/markdown"} | |
authors = [ | ||
{ name = "Yash kalathiya", email = "[email protected]" }, | ||
] | ||
dependencies = [ | ||
"data-prep-toolkit==0.2.2.dev0", | ||
"scancode-toolkit==32.1.0", | ||
] | ||
dynamic = ["dependencies"] | ||
|
||
[build-system] | ||
requires = ["setuptools>=68.0.0", "wheel", "setuptools_scm[toml]>=7.1.0"] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[tool.setuptools.dynamic] | ||
dependencies = {file = ["requirements.txt"]} | ||
|
||
|
||
[project.optional-dependencies] | ||
dev = [ | ||
"twine", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
data-prep-toolkit==0.2.2.dev0 | ||
scancode-toolkit==32.1.0 ; platform_system != 'Darwin' | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[project] | ||
name = "dpk_license_select_transform_python" | ||
version = "0.2.1.dev0" | ||
version = "0.2.2.dev0" | ||
requires-python = ">=3.10" | ||
description = "License Select Python Transform" | ||
license = {text = "Apache-2.0"} | ||
|
@@ -9,14 +9,16 @@ authors = [ | |
{ name = "Shivdeep Singh", email = "[email protected]" }, | ||
{ name = "Mark Lewis", email = "[email protected]" }, | ||
] | ||
dependencies = [ | ||
"data-prep-toolkit==0.2.1.dev0", | ||
] | ||
dynamic = ["dependencies"] | ||
|
||
[build-system] | ||
requires = ["setuptools>=68.0.0", "wheel", "setuptools_scm[toml]>=7.1.0"] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[tool.setuptools.dynamic] | ||
dependencies = {file = ["requirements.txt"]} | ||
|
||
|
||
[project.optional-dependencies] | ||
dev = [ | ||
"twine", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
data-prep-toolkit==0.2.2.dev0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[project] | ||
name = "dpk_license_select_transform_ray" | ||
version = "0.2.1.dev0" | ||
version = "0.2.2.dev0" | ||
requires-python = ">=3.10" | ||
description = "License Select Transform" | ||
license = {text = "Apache-2.0"} | ||
|
@@ -10,8 +10,8 @@ authors = [ | |
{ name = "Mark Lewis", email = "[email protected]" }, | ||
] | ||
dependencies = [ | ||
"dpk-license-select-transform-python==0.2.1.dev0", | ||
"data-prep-toolkit-ray==0.2.1.dev0", | ||
"dpk-license-select-transform-python==0.2.2.dev0", | ||
"data-prep-toolkit-ray==0.2.2.dev0", | ||
] | ||
|
||
[build-system] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,14 +8,16 @@ readme = {file = "README.md", content-type = "text/markdown"} | |
authors = [ | ||
{ name = "Shivdeep Singh", email = "[email protected]" }, | ||
] | ||
dependencies = [ | ||
"data-prep-toolkit==0.2.2.dev0", | ||
] | ||
dynamic = ["dependencies"] | ||
|
||
[build-system] | ||
requires = ["setuptools>=68.0.0", "wheel", "setuptools_scm[toml]>=7.1.0"] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[tool.setuptools.dynamic] | ||
dependencies = {file = ["requirements.txt"]} | ||
|
||
|
||
[project.optional-dependencies] | ||
dev = [ | ||
"twine", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
data-prep-toolkit==0.2.2.dev0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,16 +10,15 @@ authors = [ | |
{ name = "Panos Vagenas", email = "[email protected]" }, | ||
{ name = "Christoph Auer", email = "[email protected]" }, | ||
] | ||
dependencies = [ | ||
"data-prep-toolkit==0.2.2.dev0", | ||
"docling-core==1.3.0", | ||
"llama-index-core>=0.11.0,<0.12.0", | ||
] | ||
dynamic = ["dependencies"] | ||
|
||
[build-system] | ||
requires = ["setuptools>=68.0.0", "wheel", "setuptools_scm[toml]>=7.1.0"] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[tool.setuptools.dynamic] | ||
dependencies = {file = ["requirements.txt"]} | ||
|
||
[project.optional-dependencies] | ||
dev = [ | ||
"twine", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
data-prep-toolkit==0.2.2.dev0 | ||
docling-core==1.3.0 | ||
llama-index-core>=0.11.0,<0.12.0 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we renaming BUILD_WHEEL_ARG to PYTHON_BUILD_EXTRA_ARGS to match DOCKER_BUILD_EXTRA_ARGS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and a default (empty?) should be defined above, similar to DOCKER_BUILD_EXTRA_ARGS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @daw3rd . No need for Default. The default is none anyway.