Update HAP README.md

[ian-cho]

updated hap README @shahrokhDaijavad

Why are these changes needed?

• addressed the issues in the comments about having default values for the configuration for the key values
• added default values
• used contents as column name instead of doc_text
• added a hyperlink for NLTK

Related issue number (if any).

#659

[touma-I]

thank @ian-cho for the quick action. Should you also update the code so the default value is also reflected in the column name when the users do NOT pass it as a parameter value? let me know if this makes sense. thanks

More specifically: lines 30, 31 and 32 of hap_transform.py

        self.model_name_or_path = config.get("model_name_or_path")
        self.annotation_column = config.get("annotation_column")
        self.doc_text_column = config.get("doc_text_column")

[touma-I]

@ian-cho Please take a look here #638 and see if any of the comments from the previous PR can be addressed in this one. Thanks again. cc: @shahrokhDaijavad

[ian-cho]

thank @ian-cho for the quick action. Should you also update the code so the default value is also reflected in the column name when the users do NOT pass it as a parameter value? let me know if this makes sense. thanks

More specifically: lines 30, 31 and 32 of hap_transform.py

        self.model_name_or_path = config.get("model_name_or_path")
        self.annotation_column = config.get("annotation_column")
        self.doc_text_column = config.get("doc_text_column")

Thanks. I am also going to do that. Just wonder if self.model_name_or_path = config.get("model_name_or_path", "ibm-granite/granite-guardian-hap-38m") is okay?

[ian-cho]

thank @ian-cho for the quick action. Should you also update the code so the default value is also reflected in the column name when the users do NOT pass it as a parameter value? let me know if this makes sense. thanks

More specifically: lines 30, 31 and 32 of hap_transform.py

        self.model_name_or_path = config.get("model_name_or_path")
        self.annotation_column = config.get("annotation_column")
        self.doc_text_column = config.get("doc_text_column")

made according changes in this pull request #663

[shahrokhDaijavad]

Thank you, @ian-cho . LGTM. I will do a new PR adding hap to the table in the root README file.