readme and makefile fixes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blublinsky
force-pushed
the
kind-kfp-fixes
branch
from
02b3448 to
e43ed08
Compare
roytman
approved these changes
Apr 25, 2024
kind/README.md
Outdated
| @@ -25,10 +26,10 @@ Run the following command to create the cluster: | |||
|
|
|||
| ```shell | |||
| cd /tmp | |||
| git clone [email protected]:IBM/data-prep-lab.git | |||
| cd data-prep-lab | |||
| git clone [email protected]:ai-models-data/fm-data-engineering.git | |||
There was a problem hiding this comment.
should it be [email protected]/IBM/data-prep-lab.git
cd data-prep-lab
Why did you change it?
| @@ -10,6 +10,34 @@ kind_delete() { | |||
| } | |||
|
|
|||
| kind_create() { | |||
| if ! command -v lsof &> /dev/null ; then | |||
Signed-off-by: blublinsky <[email protected]>
Signed-off-by: blublinsky <[email protected]>
blublinsky
force-pushed
the
kind-kfp-fixes
branch
from
23ff434 to
e6b4a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.