Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small changes to get ready for pdf #261

Merged
merged 2 commits into from
Jun 11, 2024
Merged

small changes to get ready for pdf #261

merged 2 commits into from
Jun 11, 2024

Conversation

blublinsky
Copy link
Collaborator

Why are these changes needed?

There are currently 2 main issues for implementing pdf conversion:

  1. PDF conversion is based on 2 files - *.csv and *.pdf. So we do need to process them as a pair. Both files have the same name but two different extensions. The solution is to only read *.csv file and then convert the name to get a pdf extension. Something like this:
pdf_name = TransformUtils.get_file_extension(file_name)[0] + ".pdf" 

and then read a pdf file

  1. As PDF is doing conversion from *.csv to *.parquet, the checkpointing is broken. Here checkpointing is fixed by:
    a. introducing a new parameter files_to_checkpoint. default is [.parquet]
    b. comparing just the full names without extensions for the purposes of checkpointing

Related issue number (if any).

@blublinsky blublinsky requested a review from daw3rd June 11, 2024 12:13
Copy link
Member

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blublinsky

@blublinsky blublinsky requested a review from daw3rd June 11, 2024 13:46
@daw3rd daw3rd merged commit d468da0 into dev Jun 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants