Made tha review changes requested

1. Updated makefiles to new the format used in noop 2. Updated author names in toml file Signed-off-by: aishwariyachakraborty <[email protected]>
IBM · Oct 4, 2024 · 15de249 · 15de249
1 parent ec3998e
commit 15de249
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 18 deletions.
diff --git a/transforms/code/higher_order_syntactic_profiler/Makefile b/transforms/code/higher_order_syntactic_profiler/Makefile
@@ -55,16 +55,24 @@ docker-save-image::
 
 .PHONY: workflow-venv
 workflow-venv:
-	$(MAKE) -C kfp_ray workflow-venv
+	if [ -e kfp_ray ]; then                 \
+	    $(MAKE) -C kfp_ray workflow-venv;   \
+	fi
 
 .PHONY: workflow-test
 workflow-test:
-	$(MAKE) -C kfp_ray workflow-test
-
+	if [ -e kfp_ray ]; then                 \
+	    $(MAKE) -C kfp_ray workflow-test;   \
+	fi
+
 .PHONY: workflow-upload
 workflow-upload:
-	$(MAKE) -C kfp_ray workflow-upload
+	if [ -e kfp_ray ]; then                 \
+	    $(MAKE) -C kfp_ray workflow-upload; \
+	fi
 
 .PHONY: workflow-build
 workflow-build:
-	$(MAKE) -C  kfp_ray workflow-build
+	if [ -e kfp_ray ]; then                 \
+	    $(MAKE) -C  kfp_ray workflow-build; \
+	fi
diff --git a/transforms/code/higher_order_syntactic_profiler/python/pyproject.toml b/transforms/code/higher_order_syntactic_profiler/python/pyproject.toml
@@ -6,8 +6,7 @@ description = "Higher Order Syntactic Profiler Python Transform"
 license = {text = "Apache-2.0"}
 readme = {file = "README.md", content-type = "text/markdown"}
 authors = [
-    { name = "David Wood", email = "[email protected]" },
-    { name = "Boris Lublinsky", email = "[email protected]" },
+    { name = "Aishwariya Chakraborty", email = "[email protected]" },
 ]
 dependencies = [
     "data-prep-toolkit==0.2.1.dev0",

diff --git a/transforms/code/higher_order_syntactic_profiler/ray/pyproject.toml b/transforms/code/higher_order_syntactic_profiler/ray/pyproject.toml
@@ -6,8 +6,7 @@ description = "HOSP Ray Transform"
 license = {text = "Apache-2.0"}
 readme = {file = "README.md", content-type = "text/markdown"}
 authors = [
-    { name = "David Wood", email = "[email protected]" },
-    { name = "Boris Lublinsky", email = "[email protected]" },
+    { name = "Aishwariya Chakraborty", email = "[email protected]" },
 ]
 dependencies = [
     "dpk-hosp-transform-python==0.2.1.dev0",

diff --git a/transforms/code/semantic_profiler/Makefile b/transforms/code/semantic_profiler/Makefile
@@ -55,16 +55,24 @@ docker-save-image::
 
 .PHONY: workflow-venv
 workflow-venv:
-	$(MAKE) -C kfp_ray workflow-venv
+	if [ -e kfp_ray ]; then                 \
+	    $(MAKE) -C kfp_ray workflow-venv;   \
+	fi
 
 .PHONY: workflow-test
 workflow-test:
-	$(MAKE) -C kfp_ray workflow-test
-
+	if [ -e kfp_ray ]; then                 \
+	    $(MAKE) -C kfp_ray workflow-test;   \
+	fi
+
 .PHONY: workflow-upload
 workflow-upload:
-	$(MAKE) -C kfp_ray workflow-upload
+	if [ -e kfp_ray ]; then                 \
+	    $(MAKE) -C kfp_ray workflow-upload; \
+	fi
 
 .PHONY: workflow-build
 workflow-build:
-	$(MAKE) -C  kfp_ray workflow-build
+	if [ -e kfp_ray ]; then                 \
+	    $(MAKE) -C  kfp_ray workflow-build; \
+	fi
diff --git a/transforms/code/semantic_profiler/python/pyproject.toml b/transforms/code/semantic_profiler/python/pyproject.toml
@@ -6,8 +6,7 @@ description = "SemanticProfiler Python Transform"
 license = {text = "Apache-2.0"}
 readme = {file = "README.md", content-type = "text/markdown"}
 authors = [
-    { name = "David Wood", email = "[email protected]" },
-    { name = "Boris Lublinsky", email = "[email protected]" },
+    { name = "Aishwariya Chakraborty", email = "[email protected]" },
 ]
 dependencies = [
     "data-prep-toolkit==0.2.1.dev0",

diff --git a/transforms/code/semantic_profiler/ray/pyproject.toml b/transforms/code/semantic_profiler/ray/pyproject.toml
@@ -6,8 +6,7 @@ description = "SP Ray Transform"
 license = {text = "Apache-2.0"}
 readme = {file = "README.md", content-type = "text/markdown"}
 authors = [
-    { name = "David Wood", email = "[email protected]" },
-    { name = "Boris Lublinsky", email = "[email protected]" },
+    { name = "Aishwariya Chakraborty", email = "[email protected]" },
 ]
 dependencies = [
     "dpk-sp-transform-python==0.2.1.dev0",