Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded App Configuration go admin SDK to latest version, Replaced plain fmt error function with flex error function #5883

Merged
merged 14 commits into from
Dec 23, 2024

Conversation

prajwal-jarali
Copy link
Contributor

PR Details:-

  • App Configuration go admin SDK is upgraded to 0.4.4 version which is generated by openai-sdkgen from latest api-spec file.
  • As requested by Terraform team all plain fmt error functions are now replaced with flex fmtError function for better readable error messages.
  • Environment test file is now made to use lite plan instead of standard plan as test can be completed in lite plan only.
  • Segments test cases which were expecting first and last attribute in response are removed as terraform doesn't include them in response.
  • Simple Href is now replaced with first, last, next, previous types in the respective place-holders

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

  1. make build
prajwaljarali@Prajwals-MacBook-Pro terraform-provider-ibm % make build
==> Checking that code complies with gofmt requirements...
go vet .
go install
  1. Individual tests->
=== RUN   TestAccIbmAppConfigCollectionDataSource
--- PASS: TestAccIbmAppConfigCollectionDataSource (61.87s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        63.182s
=== RUN   TestAccIbmAppConfigCollectionsDataSource
--- PASS: TestAccIbmAppConfigCollectionsDataSource (61.08s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        62.386s
=== RUN   TestAccIbmAppConfigEnvironmentDataSourceBasic
--- PASS: TestAccIbmAppConfigEnvironmentDataSourceBasic (69.63s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        71.162s
=== RUN   TestAccIbmAppConfigEnvironmentsDataSourceBasic
--- PASS: TestAccIbmAppConfigEnvironmentsDataSourceBasic (27.04s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        28.668s
=== RUN   TestAccIbmAppConfigFeatureDataSource
--- PASS: TestAccIbmAppConfigFeatureDataSource (73.92s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        75.219s
=== RUN   TestAccIbmAppConfigFeaturesDataSourceBasic
--- PASS: TestAccIbmAppConfigFeaturesDataSourceBasic (65.63s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        67.161s
=== RUN   TestAccIbmAppConfigPropertyDataSource
collectionscollectionscollectionscollections--- PASS: TestAccIbmAppConfigPropertyDataSource (61.82s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        63.390s
=== RUN   TestAccIbmAppConfigPropertiesDataSourceBasic
--- PASS: TestAccIbmAppConfigPropertiesDataSourceBasic (68.35s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        69.643s
=== RUN   TestAccIbmAppConfigSegmentDataSource
--- PASS: TestAccIbmAppConfigSegmentDataSource (58.24s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        59.504s
=== RUN   TestAccIbmAppConfigSegmentsDataSourceBasic
--- PASS: TestAccIbmAppConfigSegmentsDataSourceBasic (59.99s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        61.995s
=== RUN   TestAccIbmAppConfigEnvironmentBasic
--- PASS: TestAccIbmAppConfigEnvironmentBasic (74.50s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        76.115s
=== RUN   TestAccIbmIbmAppConfigFeatureBasic
--- PASS: TestAccIbmIbmAppConfigFeatureBasic (77.32s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        78.830s
=== RUN   TestAccIbmIbmAppConfigCollectionBasic
--- PASS: TestAccIbmIbmAppConfigCollectionBasic (71.60s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        72.916s
=== RUN   TestAccIbmIbmAppConfigPropertyBasic
--- PASS: TestAccIbmIbmAppConfigPropertyBasic (77.27s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        78.573s
=== RUN   TestAccIbmIbmAppConfigSegmentBasic
--- PASS: TestAccIbmIbmAppConfigSegmentBasic (75.98s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/appconfiguration        77.236s

@hkantare hkantare merged commit 5d3e05d into IBM-Cloud:master Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants