Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListClassicWorkers => ListAllWorkers #5784

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

bevicted
Copy link
Contributor

@bevicted bevicted commented Nov 12, 2024

Requires IBM-Cloud/bluemix-go#451

Underlying api call was changed as the old one was faulty

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

❯ make testacc TEST=./ibm/service/kubernetes TESTARGS='-run "TestAccIBMContainerCluster_basic"'

=== RUN   TestAccIBMContainerCluster_basic
--- PASS: TestAccIBMContainerCluster_basic (4475.05s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      4475.844s

Bence Vidosits added 2 commits November 12, 2024 10:29
Signed-off-by: Bence Vidosits <[email protected]>
@bevicted
Copy link
Contributor Author

Re-ran acc test just to be sure

❯ make testacc TEST=./ibm/service/kubernetes TESTARGS='-run "TestAccIBMContainerCluster_basic"'
=== RUN   TestAccIBMContainerCluster_basic
--- PASS: TestAccIBMContainerCluster_basic (19745.39s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      19746.220s

@bevicted bevicted marked this pull request as ready for review November 14, 2024 16:54
@hkantare hkantare merged commit d20a670 into IBM-Cloud:master Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants