Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Granular CRN for shared processor pool data sources and resources #5650

Merged
merged 25 commits into from
Oct 4, 2024
Merged

Granular CRN for shared processor pool data sources and resources #5650

merged 25 commits into from
Oct 4, 2024

Conversation

Alexander-Kita
Copy link
Collaborator

@Alexander-Kita Alexander-Kita commented Sep 17, 2024 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_shared_processor_pool (d):

=== RUN   TestAccIBMPIPISharedProcessorPoolDataSource_basic
--- PASS: TestAccIBMPIPISharedProcessorPoolDataSource_basic (26.84s)
PASS

pi_shared_processor_pools (d):

=== RUN   TestAccIBMPISharedProcessorPoolsDataSourceBasic
--- PASS: TestAccIBMPISharedProcessorPoolsDataSourceBasic (11.94s)
PASS

pi_shared_processor_pool (r):

=== RUN   TestAccIBMPISPPbasic
--- PASS: TestAccIBMPISPPbasic (49.45s)
PASS

=== RUN   TestAccIBMPISPPUserTags
--- PASS: TestAccIBMPISPPUserTags (96.87s)
PASS

@Alexander-Kita Alexander-Kita added the service/Power Systems Issues related to Power Systems label Sep 17, 2024
@Alexander-Kita
Copy link
Collaborator Author

@yussufsh, @hkantare Can you please review this PR which part of power Q3

ismirlia
ismirlia previously approved these changes Sep 18, 2024
View reviewed changes
ismirlia
ismirlia previously approved these changes Sep 20, 2024
View reviewed changes
Alexander-Kita and others added 20 commits September 23, 2024 11:25
ismirlia
ismirlia previously approved these changes Sep 23, 2024
View reviewed changes
ismirlia
ismirlia previously approved these changes Sep 27, 2024
View reviewed changes
michaelkad
michaelkad reviewed Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate code

@Alexander-Kita Alexander-Kita force-pushed the crn-spp branch 2 times, most recently from 79a0b44 to a78a3af Compare September 27, 2024 16:35
ismirlia
ismirlia previously approved these changes Sep 27, 2024
View reviewed changes
michaelkad
michaelkad previously approved these changes Oct 1, 2024
View reviewed changes
@michaelkad michaelkad requested a review from ismirlia October 1, 2024 21:53
michaelkad
michaelkad previously approved these changes Oct 1, 2024
View reviewed changes
@yussufsh yussufsh merged commit c2ea51f into master Oct 4, 2024
1 check passed
@Alexander-Kita Alexander-Kita deleted the crn-spp branch November 19, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@michaelkad michaelkad michaelkad left review comments

@hkantare hkantare Awaiting requested review from hkantare

@ismirlia ismirlia Awaiting requested review from ismirlia

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alexander-Kita @yussufsh @michaelkad @ismirlia