Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CIS): Origin Post Quantum Encryption and Max HTTP Version #5504

Merged
merged 13 commits into from
Aug 20, 2024

Conversation

arjunchauhanibm
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Copy link

@sheltons sheltons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline

@hkantare
Copy link
Collaborator

Fix the conflicts

@hkantare
Copy link
Collaborator

hkantare commented Aug 16, 2024

Add respective testcase and test results of all testcases associated with changed resource

@arjunchauhanibm
Copy link
Contributor Author

Test case 1.
origin_max_http_version = "1"
origin_post_quantum_encryption = "off"

image image

@arjunchauhanibm
Copy link
Contributor Author

Test case 2.
origin_max_http_version = "2"
origin_post_quantum_encryption = "preferred"

image

@arjunchauhanibm
Copy link
Contributor Author

arjunchauhanibm commented Aug 17, 2024

Test case 3.
origin_max_http_version = "2"
origin_post_quantum_encryption = "supported"

image

@hkantare hkantare merged commit 3d7eb0c into IBM-Cloud:master Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants