Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for snapshot crn #5399

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Conversation

uibm
Copy link
Collaborator

@uibm uibm commented May 31, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISVolume_snapshotcrn'
=== RUN   TestAccIBMISVolume_snapshotcrn
--- PASS: TestAccIBMISVolume_snapshotcrn (230.20s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     233.040s
=== RUN   TestAccIBMISVolume_snapshot
--- PASS: TestAccIBMISVolume_snapshot (272.53s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     275.362s
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISInstanceVolumeAttachment_crn'
=== RUN   TestAccIBMISInstanceVolumeAttachment_crn
--- PASS: TestAccIBMISInstanceVolumeAttachment_crn (232.60s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     234.586s

--- PASS: TestAccIBMISInstanceVolumeAttachment_basic (313.05s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     314.604s

--- PASS: TestAccIBMISInstanceSnapshotRestore_crn (312.05s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     313.924s

--- PASS: TestAccIBMISInstanceSnapshotRestore_basic (268.93s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     270.461s

@uibm uibm marked this pull request as ready for review May 31, 2024 05:36
@uibm uibm changed the title snapshot crn support for snapshot crn Jun 3, 2024
@uibm
Copy link
Collaborator Author

uibm commented Jun 4, 2024

=== RUN   TestAccIBMISInstance_basic
--- PASS: TestAccIBMISInstance_basic (258.65s)

=== RUN   TestAccIBMISInstance_basicwithipv4
--- PASS: TestAccIBMISInstance_basicwithipv4 (142.84s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     403.091s

@uibm
Copy link
Collaborator Author

uibm commented Jun 4, 2024

=== RUN   TestAccIBMISInstance_vni
--- PASS: TestAccIBMISInstance_vni (152.78s)
=== RUN   TestAccIBMISInstance_vni_update
--- PASS: TestAccIBMISInstance_vni_update (231.22s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     385.559s

@uibm
Copy link
Collaborator Author

uibm commented Jun 4, 2024

--- PASS: TestAccIBMISInstance_lifecycle (253.30s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     255.309s

@uibm
Copy link
Collaborator Author

uibm commented Jun 4, 2024

--- PASS: TestAccIBMISInstance_rip (168.81s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     170.382s

@uibm
Copy link
Collaborator Author

uibm commented Jun 4, 2024

--- PASS: TestAccIBMISInstance_ResizeBoot (250.20s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     252.235s
--- PASS: TestAccIBMISInstance_RenameBoot (238.28s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     240.162s

@hkantare hkantare merged commit 7b0d9e1 into IBM-Cloud:master Jun 18, 2024
1 check passed
@uibm uibm deleted the UI-36289-snapshot-crn branch June 18, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants