Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for healthstate and healthreason for vpc dns bindings #5222

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Added support for healthstate and healthreason for vpc dns bindings #5222

merged 2 commits into from
Mar 22, 2024

Conversation

uibm
Copy link
Collaborator

@uibm uibm commented Mar 20, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@uibm
Copy link
Collaborator Author

uibm commented Mar 20, 2024

before this, #5223 must go

@uibm uibm marked this pull request as ready for review March 22, 2024 05:01
@uibm uibm force-pushed the vpcdnsrb-health branch from c1aa7b7 to 2201ead Compare March 22, 2024 05:11
@uibm uibm force-pushed the vpcdnsrb-health branch from 46eaf78 to a5c7042 Compare March 22, 2024 05:16
@uibm uibm changed the title Added support for healthstate and healthreason for vpc Added support for healthstate and healthreason for vpc dns bindings Mar 22, 2024
@hkantare hkantare merged commit 1b0fbb0 into IBM-Cloud:master Mar 22, 2024
1 check passed
@uibm uibm deleted the vpcdnsrb-health branch March 25, 2024 13:26
ismirlia pushed a commit to powervs-ibm/terraform-provider-ibm that referenced this pull request Apr 11, 2024
@uibm @ismirlia
added support for health reasons and health state in vpc dns bindings (…
ecbe4f5 
…IBM-Cloud#5222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uibm @hkantare