[fix] Updated the patientEntry E2E #1455
Conversation
Bahati308
changed the title
There was a problem hiding this comment.
PR looks like it's coming along! I particularly like the use of the test-specific id selectors (data-testid, data-cy) It would be good if we could align on which specific one we want to use and stick to it. There's a few selectors that are still page-setup/class specific that I would like moved to ids if possible. And in general, updating function names to something that captures the updated functionality should always happen.
Individual comments are below. Great work!
| } | ||
|
|
||
| getTestTypePriority(priority) { | ||
| cy.get("#select-1").select(priority); | ||
| } | ||
|
|
||
| getPrintWorkPlanButton() { |
There was a problem hiding this comment.
This methods should be renamed since it is no longer a "get" operation
There was a problem hiding this comment.
surely, lemme adjust accordingly. thanks
| getWorkPlanResultsTable() { | ||
| return cy.get(".cds--data-table.cds--data-table--sm"); | ||
|
|
||
| getFinalPrintWorkPlanButton() { |
There was a problem hiding this comment.
This methods should be renamed since it is no longer a "get" operation
| acceptSample() { | ||
| //div.cds--form-item.cds--checkbox-wrapper > input[type="checkbox"] | ||
| cy.get( | ||
| 'div.cds--form-item.cds--checkbox-wrapper > input[type="checkbox"]', |
There was a problem hiding this comment.
This still looks like it is using the page format selectors. Is there a reason why an id can't be used?
There was a problem hiding this comment.
true, will harden it
| } | ||
|
|
||
| selectPatient() { | ||
| cy.get("table tbody tr").first().find("td label span").click(); |
There was a problem hiding this comment.
can an id selector be used instead of page format selectors here?
| cy.getElement( | ||
| ".navigationButtonsLayout [type='button']:nth-of-type(2)", | ||
| ).click(); | ||
| cy.get("button.forwardButton.cds--btn--primary") |
There was a problem hiding this comment.
can this be an id selector instead?
| cy.fixture("result").then((res) => { | ||
| result.acceptSample(); | ||
| result.expandSampleDetails(); | ||
| result.selectTestMethod(0, res.pcrTestMethod); | ||
| cy.get(":nth-child(3) > .cds--form-item > .cds--checkbox-label").click(); |
[fix] Updated the patientEntry E2E
Screenshots
Related Issue
https://uwdigi.atlassian.net/browse/OGC-13
Other
https://uwdigi.atlassian.net/browse/OGC-28
[Add any additional information or notes here]