Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load field form assets always since we have file fields in modals/htmx. #4442

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Load field form assets always since we have file fields in modals/htmx. #4442

merged 1 commit into from
Mar 11, 2025

Conversation

frjo
Copy link
Member

@frjo frjo commented Mar 11, 2025 •
edited
Loading

Fixes #4441

Test Steps

  • Test that file field work in dialogs, and everywhere else.

@frjo frjo requested a review from theskumar March 11, 2025 19:18
@frjo frjo mentioned this pull request Mar 11, 2025
Closed
@frjo frjo temporarily deployed to test-hypha-app March 11, 2025 19:20 Inactive
@frjo frjo added Type: Bug Bugs! Things that are broken :-/ Status: Needs testing Tickets that need testing/qa Type: Minor Minor change, used in release drafter Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Mar 11, 2025
@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Mar 11, 2025
@wes-otf
Copy link
Contributor

wes-otf commented Mar 11, 2025

works like a charm!

@frjo frjo merged commit 5233d66 into main Mar 11, 2025
12 checks passed
@theskumar theskumar deleted the fix/load_file_field_assets_always branch March 13, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theskumar theskumar Awaiting requested review from theskumar

Assignees
No one assigned
Labels
Status: Tested - approved for live ✅ Type: Bug Bugs! Things that are broken :-/ Type: Minor Minor change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to upload contracts in the contracting phase
2 participants
@frjo @wes-otf