Fix report form, allow saving as draft without filling required fields #4428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the report form validates for the required fields when saving as draft. This updates the behaviour to not validate the required fields, similar to application submision forms.
theskumar
commented
Mar 3, 2025
| (ReportEditForm,), | ||
| fields, | ||
| ) | ||
| return the_class |
There was a problem hiding this comment.
📓 This is not needed as the Parent class "BaseStreamForm" implement this function that makes use of submission_form_class class property.
frjo
approved these changes
Mar 3, 2025
frjo
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the report form validates for the required fields when saving
as draft.
This updates the behaviour to not validate the required fields, similar
to application submision forms.