Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same style for notification view as used on communication tab. #4422

Merged
merged 5 commits into from
Feb 28, 2025

Conversation

frjo
Copy link
Member

@frjo frjo commented Feb 26, 2025

Fixes #4387

Skärmavbild 2025-02-27 kl  16 06 05

@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Feb 26, 2025
@theskumar
Copy link
Member

This is great improvement!

Given across different funds these activities can be quite a lot, thought on converting it to be a paginated list with auto load similar to how it's done in the communication tab?

@theskumar
Copy link
Member

Should we update the title to save "Activity Feed" instead? same as it's on the user's menu.

Screenshot 2025-02-26 at 2  56 01@2x

@theskumar
Copy link
Member

I see there is an issue with the new feed, it's not possible to identify which project/application this particular activity belongs to.

@frjo
Copy link
Member Author

frjo commented Feb 26, 2025

Good catch, that I missed. Need to look over this more.

@theskumar
Copy link
Member

I see there is an issue with the new feed, it's not possible to identify which project/application this particular activity belongs to.

On the possibility you can explore is showing the activity in the format.

  • [noun] [verb] on [target] on [source] [timestamp]

and use the same format for the comment as well, so for the comment it will say something like.

  • X left a commented on FundX 2 days ago
  • X updated status to approve on FundX on Feb 12, 2024

@theskumar
Copy link
Member

I see there is an issue with the new feed, it's not possible to identify which project/application this particular activity belongs to.

On the possibility you can explore is showing the activity in the format.

  • [noun] [verb] on [target] on [source] [timestamp]

and use the same format for the comment as well, so for the comment it will say something like.

  • X left a commented on FundX 2 days ago
  • X updated status to approve on FundX on Feb 12, 2024

Or the id/name of application/project can be prefix in all the activities and update the comment item to use the activity item with a comment

@frjo
Copy link
Member Author

frjo commented Feb 26, 2025

Now added a fix so submission/project is visible for each comment/activity.

@frjo frjo force-pushed the enhancement/notification_view_unified branch from 627ee03 to 6d4d33c Compare February 27, 2025 14:28
@frjo
Copy link
Member Author

frjo commented Feb 27, 2025

Grouped the notification by submission/project after suggestion from @theskumar. I think that makes the view more useful in general. Looks good as well.

@frjo frjo removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Feb 28, 2025
@frjo frjo merged commit e4daf4f into main Feb 28, 2025
7 checks passed
@theskumar theskumar deleted the enhancement/notification_view_unified branch February 28, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the activity/notifications view unified like the application communication view
2 participants