Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting view all urls on staff and reviewer dashboard. #4409

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

frjo
Copy link
Member

@frjo frjo commented Feb 20, 2025

Some styling updates as well.

@frjo frjo added Type: Bug Bugs! Things that are broken :-/ Status: Needs testing Tickets that need testing/qa Type: Patch Mini change, used in release drafter Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Feb 20, 2025
Copy link
Member

@theskumar theskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the code responsible for my_reviewed.url as well.

@@ -70,7 +70,7 @@
{% if my_flagged.submissions %}
<div id="submissions-flagged" class="wrapper wrapper--bottom-space">
<h3 class="mb-2 text-xl">
<a href="{% url "apply:submissions:list" %}?query=flagged:@me">Your flagged submissions <span class="text-sm">({{ my_flagged.count }})</span></a>
<a href="{% url "apply:submissions:list" %}?query=flagged:@me">Your flagged submissions <span class="py-0.5 px-2.5 text-sm font-medium text-blue-800 bg-blue-100 rounded me-2">{{ my_flagged.count }}</span></a>
</h3>

{% include "submissions/partials/submissions-inline.html" with submissions=my_flagged.submissions row_layout="table" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update at these places as well?

Remove

"url": reverse("funds:submissions:list"),

"url": reverse("funds:submissions:list"),

@frjo frjo force-pushed the fix/correcting-urls-dashboard branch from cb80e63 to c89b396 Compare February 22, 2025 09:11
@frjo frjo removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Feb 24, 2025
@frjo frjo merged commit 87d16e0 into main Feb 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bugs! Things that are broken :-/ Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants