Unify messages styles #4374
Merged
Unify messages styles #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frjo
added
Type: Enhancement
wes-otf
reviewed
Feb 6, 2025
| </button> | ||
| {% endif %} | ||
| </div> | ||
| {% heroicon_outline "check" stroke_width=2 class="inline-block w-4 h-4 me-1" aria_hidden=true %} |
There was a problem hiding this comment.
everything worked well, definitely feels much more consistent! super minor but the toast popup uses check-circle, not sure if it matters to make the two the same
hypha/hypha/templates/includes/_toast-placeholder.html
Lines 120 to 122 in 88ccdc8
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
frjo
added a commit
that referenced
this pull request
Feb 12, 2025
This updates the full page load to use the same mechanism to display the messages from `django.contrib.messages` as used during htmx request This is achieved by generating a javascript custom event for toast component instead of rendering html content. Add/update icons and color for different message types and handle long words and urls The web accessibility is maintained as the toast component handles it when it's is initialized. This is a further enhancement to #4374 to keep things DRY and consistent. --------- Co-authored-by: Fredrik Jonsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4373
The htmx/toast messages and the django messages now use similar style and the same colours for error/success/info etc.
Also fixed some translations and related styling.
Test Steps