Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stylelint rules that are no longer needed with later versions. #4303

Merged
merged 1 commit into from
Dec 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 0 additions & 64 deletions .stylelintrc.yaml
Original file line number Diff line number Diff line change
@@ -1,73 +1,9 @@
extends:
- stylelint-config-standard
- stylelint-config-standard-scss
rules:
at-rule-disallowed-list:
- debug
at-rule-no-unknown: null
at-rule-no-vendor-prefix: true
block-no-empty: null
color-hex-length: short
color-named: never
color-no-invalid-hex: true
declaration-block-no-redundant-longhand-properties: null
declaration-block-single-line-max-declarations: 1
declaration-empty-line-before: null
declaration-no-important: true
declaration-property-value-disallowed-list:
border:
- none
border-top:
- none
border-right:
- none
border-bottom:
- none
border-left:
- none
font-family-name-quotes: null
function-url-quotes: always
length-zero-no-unit: true
max-nesting-depth:
- 4
- ignoreAtRules:
- each
- media
- supports
- include
media-feature-name-no-vendor-prefix: true
media-feature-range-notation: prefix
no-descending-specificity: null
property-no-unknown: true
property-no-vendor-prefix: true
rule-empty-line-before:
- always-multi-line
- except:
- first-nested
ignore:
- after-comment
scss/at-extend-no-missing-placeholder: true
scss/at-function-pattern: "^[a-z]+([a-z0-9-]+[a-z0-9]+)?$"
scss/load-no-partial-leading-underscore: true
scss/at-import-partial-extension-disallowed-list:
- scss
scss/at-mixin-pattern: "^[a-z]+([a-z0-9-]+[a-z0-9]+)?$"
scss/at-rule-no-unknown: true
scss/comment-no-empty: null
#scss/dollar-variable-colon-space-after: always
scss/dollar-variable-colon-space-before: never
scss/dollar-variable-pattern: "^[_]?[a-z]+([a-z0-9-]+[a-z0-9]+)?$"
scss/no-global-function-names: null
#scss/percent-placeholder-pattern: "^[a-z]+([a-z0-9-]+[a-z0-9]+)?$"
#scss/selector-no-redundant-nesting-selector: true
selector-class-pattern:
- "^[a-z0-9\\-]+$"
- message: Selector should be written in lowercase with hyphens (selector-class-pattern)
selector-max-compound-selectors: 3
selector-max-id: 0
#selector-no-qualifying-type: true
selector-no-vendor-prefix: true
selector-pseudo-element-colon-notation: double
selector-pseudo-element-no-unknown: true
shorthand-property-no-redundant-values: true
value-no-vendor-prefix: true
5 changes: 2 additions & 3 deletions hypha/static_src/sass/abstracts/_mixins.scss
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
@use "sass:list";
@use "functions";
@use "variables";

// stylelint-disable

@use "sass:math";

// stylelint-disable scss/at-mixin-pattern

// Media queries
@mixin media-query($queries...) {
@each $query in $queries {
Expand Down
2 changes: 2 additions & 0 deletions hypha/static_src/sass/abstracts/_variables.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// stylelint-disable scss/dollar-variable-pattern

// Most variables are set from css variables defined in
// tailwind/base/variables.css so they are easy to override.
// Only variables used in media queries and calculations are defined here.
Expand Down
1 change: 0 additions & 1 deletion hypha/static_src/sass/base/_base.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
@use "../abstracts/variables";

// stylelint-disable property-no-vendor-prefix
body {
overflow-x: hidden;

Expand Down
2 changes: 0 additions & 2 deletions hypha/static_src/sass/components/_all-reviews-table.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@use "../abstracts/mixins";
@use "../abstracts/variables";

// stylelint-disable selector-max-compound-selectors

.all-reviews-table {
@include mixins.table-ordering-styles;

Expand Down
3 changes: 1 addition & 2 deletions hypha/static_src/sass/components/_all-submissions-table.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@use "../abstracts/mixins";
@use "../abstracts/variables";

// stylelint-disable selector-class-pattern,selector-max-compound-selectors
// stylelint-disable selector-class-pattern

.all-submissions-table {
@include mixins.table-ordering-styles;
Expand Down Expand Up @@ -177,7 +177,6 @@
}
}

// stylelint-disable-next-line force-element-nesting
> span.mobile-label {
display: inline-block;
width: 90px;
Expand Down
1 change: 0 additions & 1 deletion hypha/static_src/sass/components/_button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@
}

&--login {
/* stylelint-disable-next-line media-query-no-invalid */
@media (min-width: variables.$input-box-max-width) {
width: 20rem;
}
Expand Down
3 changes: 0 additions & 3 deletions hypha/static_src/sass/components/_dashboard-table.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@use "../abstracts/mixins";
@use "../abstracts/variables";

// stylelint-disable selector-max-compound-selectors

.paf-review-table {
@include mixins.table-ordering-styles;

Expand Down Expand Up @@ -41,7 +39,6 @@

tbody {
td {
// stylelint-disable-next-line force-element-nesting
> span.mobile-label {
display: inline-block;
width: 90px;
Expand Down
1 change: 0 additions & 1 deletion hypha/static_src/sass/components/_feed.scss
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@

span {
&:first-child {
// stylelint-disable-next-line max-nesting-depth
&::after {
@include mixins.triangle(
right,
Expand Down
8 changes: 2 additions & 6 deletions hypha/static_src/sass/components/_form.scss
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
@use "../base/base";
@use "../abstracts/mixins";
@use "../abstracts/variables";

// stylelint-disable selector-max-compound-selectors

@use "sass:math";

.form {
Expand Down Expand Up @@ -260,7 +257,6 @@
}

input {
// stylelint-disable-next-line max-nesting-depth
&:first-of-type {
@supports (display: grid) {
grid-column: 1;
Expand Down Expand Up @@ -455,7 +451,7 @@
}

&__comments {
// stylelint-disable-next-line selector-class-pattern,selector-id-pattern,selector-max-id
// stylelint-disable-next-line selector-class-pattern,selector-id-pattern
ul#id_visibility {
display: flex;
flex-wrap: wrap;
Expand Down Expand Up @@ -487,7 +483,7 @@

.address {
padding: 0.4em;
border: 1px solid #cfcfcf8f; // stylelint-disable-line color-no-hex
border: 1px solid #cfcfcf8f;
max-width: 410px;

// stylelint-disable-next-line selector-class-pattern
Expand Down
2 changes: 1 addition & 1 deletion hypha/static_src/sass/components/_nprogress.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@use "../abstracts/variables";

/* stylelint-disable selector-max-id, length-zero-no-unit -- CSS from https://github.com/rstacruz/nprogress */
/* stylelint-disable length-zero-no-unit -- CSS from https://github.com/rstacruz/nprogress */
#nprogress {
/* Make clicks pass-through */
pointer-events: none;
Expand Down
4 changes: 0 additions & 4 deletions hypha/static_src/sass/components/_projects-table.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@use "../abstracts/mixins";
@use "../abstracts/variables";

// stylelint-disable selector-max-compound-selectors

.projects-table {
@include mixins.table-ordering-styles;

Expand All @@ -16,7 +14,6 @@

tbody {
td {
// stylelint-disable-next-line force-element-nesting
> span.mobile-label {
display: inline-block;
width: 90px;
Expand Down Expand Up @@ -62,7 +59,6 @@

tbody {
td {
// stylelint-disable-next-line force-element-nesting
> span.mobile-label {
display: inline-block;
width: 90px;
Expand Down
2 changes: 0 additions & 2 deletions hypha/static_src/sass/components/_reviews-sidebar.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@use "../abstracts/mixins";
@use "../abstracts/variables";

// stylelint-disable max-nesting-depth

.reviews-sidebar {
$root: &;
margin-block-end: 20px;
Expand Down
5 changes: 1 addition & 4 deletions hypha/static_src/sass/components/_select2.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@use "../abstracts/mixins";
@use "../abstracts/variables";

// stylelint-disable selector-max-compound-selectors, selector-class-pattern
// stylelint-disable selector-class-pattern

.select2 {
&-container {
Expand All @@ -10,7 +10,6 @@

.select2-container--default,
&.select2-container--default {
// stylelint-disable-next-line declaration-no-important
width: 100% !important;

.select2-selection--single {
Expand Down Expand Up @@ -58,9 +57,7 @@
.select2-container {
&--default {
.select2-results__option--highlighted[aria-selected] {
// stylelint-disable-next-line declaration-no-important
color: variables.$color--default !important;
// stylelint-disable declaration-no-important, max-line-length
background-color: variables.$color--light-blue-90 !important;
}
}
Expand Down
1 change: 0 additions & 1 deletion hypha/static_src/sass/components/_submission-meta.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
tbody {
td {
&.phase {
// stylelint-disable-next-line selector-max-compound-selectors
span {
display: inline-block;
padding: 10px;
Expand Down
2 changes: 0 additions & 2 deletions hypha/static_src/sass/components/_table.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@use "../abstracts/mixins";
@use "../abstracts/variables";

// stylelint-disable selector-max-compound-selectors,max-nesting-depth

.table-container {
> table {
border: 1px solid variables.$color--light-mid-grey;
Expand Down
2 changes: 1 addition & 1 deletion hypha/static_src/sass/components/_tabs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
background-color: rgba(
#fff,
0.8
); // stylelint-disable-line color-no-hex
);
}

&--alt {
Expand Down
2 changes: 1 addition & 1 deletion hypha/static_src/sass/components/_two-factor.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// stylelint-disable property-no-vendor-prefix, selector-id-pattern, selector-max-id
// stylelint-disable property-no-vendor-prefix, selector-id-pattern
@use "../base/typography";

.two-factor {
Expand Down
1 change: 0 additions & 1 deletion hypha/static_src/sass/print.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// stylelint-disable color-no-hex, no-color-literals, declaration-no-important
// stylelint-disable property-no-vendor-prefix, selector-class-pattern
* {
background: transparent !important;
Expand Down
2 changes: 2 additions & 0 deletions hypha/static_src/sass/wagtail_users_list.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// stylelint-disable media-feature-range-notation

.users-list {
padding-inline-start: 1rem;
padding-inline-end: 1rem;
Expand Down
Loading