Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily move jQuery back to being loaded in the head until we have fixed all scripts getting loaded mid page #4286

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Temporarily move jQuery back to being loaded in the head until we have fixed all scripts getting loaded mid page #4286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions hypha/templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@
<script type="module" src="{% static 'js/esm/github-relative-time-element-4-3-0.js' %}"></script>
<script type="module" src="{% static 'js/esm/github-filter-input-element-0-1-1.js' %}"></script>

<!-- We still need jQuery for select2, daterangepicker and a few custom scripts. -->
<!-- Please do not add new features that require jQuery! -->
<script src="{% static 'js/vendor/jquery.min.js' %}"></script>

{% include "includes/head_end.html" %}
</head>

Expand Down Expand Up @@ -121,11 +125,6 @@
{% include "includes/_modal-placeholder.html" %}
{% include "includes/_toast-placeholder.html" %}

<!-- We still need jQuery for select2, daterangepicker and a few custom scripts. -->
<!-- All jQuery code is loaded in "extra_js" so it should be loaded just before. -->
<!-- Please do not add new features that require jQuery! -->
<script src="{% static 'js/vendor/jquery.min.js' %}"></script>

{% block extra_js %}{% endblock %}

{% block sentry_sdk %}
Expand Down
Loading