Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reviews to project form exports. Set size to use PDFPageSettings … #4281

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

frjo
Copy link
Member

@frjo frjo commented Dec 13, 2024

…that now defaults to A4. Improv styling, docx export do not support rowspan.

Fixes #4259

Test Steps

  • Test exporting proposal form in PDF and DOCX. Confirm they look ok and include reviews.

…that now defaults to A4. Improv styling, docx export do not support rowspan.
@frjo frjo force-pushed the enhancement/add-reviews-project-form-export branch from 5e3f2d4 to bf2c439 Compare December 13, 2024 10:39
@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Minor Minor change, used in release drafter Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Dec 13, 2024
@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Dec 13, 2024
@frjo frjo merged commit 6eee33f into main Dec 13, 2024
7 checks passed
@frjo frjo deleted the enhancement/add-reviews-project-form-export branch March 11, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Tested - approved for live ✅ Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Minor Minor change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Reviews section in Project Form rendered PDF/DOCX
2 participants