Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default reporting frequency as disable #4272

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

sandeepsajan0
Copy link
Member

Fixes #4233

Test Steps

@sandeepsajan0 sandeepsajan0 marked this pull request as ready for review December 10, 2024 11:21
@frjo
Copy link
Member

frjo commented Dec 10, 2024

@wes-otf What do you think OTF prefer.

To me it feels like disabling reports by default is the best option.

The current default is once per month and in most cases that will need to be changed in any case I assume.

A future improvement could be to add a report frequency default on funds/labs.

@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Dec 12, 2024
@frjo
Copy link
Member

frjo commented Dec 16, 2024

This PR has a migration conflict with #4261 so need to hold a bit.

@frjo frjo force-pushed the enhancement/gh-4233-default-reporting-frequency branch from a35fe6a to b37f0a2 Compare December 17, 2024 19:02
@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Dec 17, 2024
@frjo frjo removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jan 2, 2025
@frjo frjo merged commit 1effd6e into main Jan 2, 2025
12 checks passed
@frjo frjo deleted the enhancement/gh-4233-default-reporting-frequency branch March 11, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set reporting frequency default to disabled
3 participants