Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dir auto via js on all p tags in applications. #4266

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

frjo
Copy link
Member

@frjo frjo commented Dec 9, 2024

Fixes #4265

With dir auto:

Skärmavbild 2024-12-09 kl  08 31 35

Without dir auto:

Skärmavbild 2024-12-09 kl  08 31 53

Test Steps

  • Submit an application with some answers in ltr langiage and some in rtl languages (e.g. Arabic). The paragraphs with rtl languages should show up as rtl automatically.

@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter labels Dec 9, 2024
@theskumar
Copy link
Member

theskumar commented Dec 9, 2024

Looks good. Thinking out loud:

  1. Do we need to cover up for for field types?
  2. Is there is way to apply it to parent level element, ie..g on the submission detail something i.e. applying to all paragraphs on the submissions. something equivalent to css property: p > * You already answered in the parent issue.

@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Dec 9, 2024
@frjo
Copy link
Member Author

frjo commented Dec 9, 2024

The solution in this PR will only work for markdown and rich text textareas. Can be improved but should cover most of the texts.

@theskumar
Copy link
Member

theskumar commented Dec 12, 2024

The solution in this PR will only work for markdown and rich text textareas. Can be improved but should cover most of the texts.

Make sense to me. As next we should look into adding this other fields as well, otherwise you end up with mixed rendering.

@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Dec 13, 2024
@frjo frjo merged commit 534dd44 into main Dec 13, 2024
7 checks passed
@theskumar theskumar deleted the enhancement/dir-auto branch March 11, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Tested - approved for live ✅ Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set dir auto on all p tags in applications so browser automatically set directionality correctly
3 participants