Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to UI of submission beta #3783

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Minor improvements to UI of submission beta #3783

merged 2 commits into from
Feb 27, 2024

Conversation

theskumar
Copy link
Member

@theskumar theskumar commented Feb 24, 2024 •
edited
Loading

Description

  • Update the row spacing, make them more comfortable for reading with increased padding top and bottom.
  • Update the ordering on the dropdown items, essentially aligns the "lead" and "reviewers" to be near the lead column and reviewers column in the rows. They are expected to align, but in one of earlier feedback people found it would be helpful if the "lead" dropdown was near the "lead" column.

Test Steps

  • Goto /apply/submissions/all-beta
  • Check the changes above are applied and looks good

image

@theskumar theskumar self-assigned this Feb 24, 2024
@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter Status: Needs user testing 👷 Tasks that should be tested by OTF's user test team labels Feb 24, 2024
@frjo frjo merged commit bec2899 into main Feb 27, 2024
10 checks passed
@theskumar theskumar deleted the submission-beta-improvements branch March 9, 2024 06:14
wes-otf pushed a commit that referenced this pull request May 7, 2024
@theskumar @wes-otf
Minor improvements to UI of submission beta (#3783)
b091fea 
- Update the row spacing, make them more comfortable for reading with
increased padding top and bottom.
- Update the ordering on the dropdown items, essentially aligns the
"lead" and "reviewers" to be near the lead column and reviewers column
in the rows. They are expected to align, but in one of earlier feedback
people found it would be helpful if the "lead" dropdown was near the
"lead" column.
wes-otf pushed a commit that referenced this pull request May 8, 2024
@theskumar @wes-otf
Minor improvements to UI of submission beta (#3783)
b391c31 
- Update the row spacing, make them more comfortable for reading with
increased padding top and bottom.
- Update the ordering on the dropdown items, essentially aligns the
"lead" and "reviewers" to be near the lead column and reviewers column
in the rows. They are expected to align, but in one of earlier feedback
people found it would be helpful if the "lead" dropdown was near the
"lead" column.
Vldln pushed a commit to equalitie/hypha that referenced this pull request May 28, 2024
@theskumar
Minor improvements to UI of submission beta (HyphaApp#3783)
618041e 
- Update the row spacing, make them more comfortable for reading with
increased padding top and bottom.
- Update the ordering on the dropdown items, essentially aligns the
"lead" and "reviewers" to be near the lead column and reviewers column
in the rows. They are expected to align, but in one of earlier feedback
people found it would be helpful if the "lead" dropdown was near the
"lead" column.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frjo frjo frjo approved these changes

@wes-otf wes-otf Awaiting requested review from wes-otf

@sandeepsajan0 sandeepsajan0 Awaiting requested review from sandeepsajan0

Assignees

@theskumar theskumar

Labels
Status: Needs user testing 👷 Tasks that should be tested by OTF's user test team Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theskumar @frjo