-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update primary nagivation dropdown UX #3769
Conversation
- Use mouseover for quick access - Update over states - Update the urls to that any external urls can also be added via settings, removes dependeny of `reverse` while specifying urls - How active page in the dropdown as well, a dark-blue border
4c34f2c
to
b50afcf
Compare
x-show="open" | ||
x-transition | ||
@click.outside="open = false" | ||
class="min-w-48 absolute block bg-white shadow-xl z-20 mt-4 border rounded-sm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min-w-48
seems to not generate any styles? Why not use min-w-max
? Having menu item break on two lines is undesirable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min-w-48
ensure the width of two dropdown are similar. It won't break them in two lines as it's not setting any max width. That said, I should consider added generous max-width so the dropdown doesn't look weird for a link with too many words.
Let me know if it all sounds reasonable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is could be b/w you are not using the latest tailwind, which introduced min-w-*
The visible-focus seems to be not working with |
@frjo any feedback on the nav getting opened while on hover? The outline issue is only happening if the mousehover is used. If mouseover is not desired, there is need to chase after the focus issue. |
cb2ab10
to
62e1330
Compare
62e1330
to
cb85761
Compare
Latest version on test now. |
Hey! Added functionality looks good to me, I'm just a little confused about what purpose the dotted border serves? I didn't see it changing on test at all, just stayed on |
- Fix the dropdown being hidden on the beta all page - Use mouseover for quick access - Update over states - Update the urls to that any external urls can also be added via settings, removes dependeny of `reverse` while specifying urls - How active page in the dropdown as well, a dark-blue border - Update the focus outline to be a simple dashed-border, instead of bulky outline
- Fix the dropdown being hidden on the beta all page - Use mouseover for quick access - Update over states - Update the urls to that any external urls can also be added via settings, removes dependeny of `reverse` while specifying urls - How active page in the dropdown as well, a dark-blue border - Update the focus outline to be a simple dashed-border, instead of bulky outline
- Fix the dropdown being hidden on the beta all page - Use mouseover for quick access - Update over states - Update the urls to that any external urls can also be added via settings, removes dependeny of `reverse` while specifying urls - How active page in the dropdown as well, a dark-blue border - Update the focus outline to be a simple dashed-border, instead of bulky outline
Description
settings, removes dependeny of
reverse
while specifying urlsTest Steps