Replace sprite svg icons with heroicons alternatives #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theskumar
force-pushed
the
maintainance/svg-updates
branch
from
d2d5b1b to
eff33da
Compare
theskumar
changed the title
frjo
approved these changes
Jan 8, 2024
theskumar
force-pushed
the
maintainance/remove-public-social-media
branch
from
62b71ec to
96cfdff
Compare
theskumar
force-pushed
the
maintainance/svg-updates
branch
from
eff33da to
469859f
Compare
I didn't fully understand this. Did you intend to say not use heroicons? As for the guess work, I believe heroicons template tags avoids the guess work, and is very explicit where the icons came from. They are also quite isolated for each use, and can be easily updated with find and replace. For the custom icons, I was thinking to use web components and be included with a template tag. Thoughts? |
frjo
added
Type: Enhancement
|
I ment that the heroicons is a good single source for all icons. |
theskumar
force-pushed
the
maintainance/svg-updates
branch
from
469859f to
d53231d
Compare
theskumar
changed the base branch from
maintainance/remove-public-social-media
to
main
theskumar
force-pushed
the
maintainance/svg-updates
branch
2 times, most recently
from
fbad3ca to
98a2a26
Compare
theskumar
changed the base branch from
main
to
maintainance/8-cookie-settings
|
Rebased on top of #3722 to avoid merge conflicts. |
theskumar
force-pushed
the
maintainance/svg-updates
branch
from
291d43f to
2b1639b
Compare
theskumar
force-pushed
the
maintainance/svg-updates
branch
from
4b1555d to
1496a0b
Compare
frjo
force-pushed
the
maintainance/8-cookie-settings
branch
from
a31b2f4 to
836ecf5
Compare
|
I have merged in all "Remove public…" PRs before this one now so this can be rebased of main. |
|
Awesome, will do it now. |
- arrow-up-short-bar - file - download - tap-phone - Flags - bell-icons - archive - mobile-menu-toggle - home - cross - magnifying-glass - filters
- Update to use alpinejs
theskumar
force-pushed
the
maintainance/svg-updates
branch
from
b579c86 to
d032b7c
Compare
theskumar
commented
Jan 30, 2024
hypha/apply/home/templates/apply_home/includes/apply_listing.html
Outdated
Show resolved
Hide resolved
frjo
requested changes
Jan 30, 2024
frjo
approved these changes
Jan 30, 2024
wes-otf
pushed a commit
that referenced
this pull request
May 7, 2024
- Upgrade heroicons to 2.6.0, adds support for heroicons_mirco - Remove/upgrade sprite icons - Update icons in the global messages widget - Remove unused bgg-logo sprite - Update calendar icon with heroicon - Update anchor-link icon - Remove speech-bubble icon and link—-open-feed, link--close-feed and link—to-top - Remove arrow-up and arrow-down - Remove arrow-split - Remove "website" icon - Remove “error” icon - Update like & dislike button in the screening section - Remove 'bulb' svg from sprite - Remove 'hero-home-left-pixels' sprite - Remove 'hero-home-right-pixels' from sprite - Remove 'magnifying-glass' svg from sprite - Remove 'person-icon' and profile_button.html - Replace 'caret-down' and 'caret-up' icon - Remove 'side-arrow' from svg sprite - Remove 'add-user' icon, replace with 'user-plus' - Remove 'logo-desktop', 'logo-mobile' and 'logo-desktop--dark' icons - Remove 'logo-mobile-no-text' icon - Remove 'logo-mobile-dark' and 'logo-desktop--dark-alt' - Remove 'hero-standard-left-pixels' and 'hero-standard-right-pixels' - Remove 'eye' icon and replace with heroicon 'eye' - Remove 'exclamation-point' icon and replace by heroicon exlaimation-circle - Remove 'github' icon - Remove 'person-icon' and profile_button.html - Replace 'caret-down' and 'caret-up' icon - Remove 'side-arrow' from svg sprite closes #3703 depends on #3722
wes-otf
pushed a commit
that referenced
this pull request
May 8, 2024
- Upgrade heroicons to 2.6.0, adds support for heroicons_mirco - Remove/upgrade sprite icons - Update icons in the global messages widget - Remove unused bgg-logo sprite - Update calendar icon with heroicon - Update anchor-link icon - Remove speech-bubble icon and link—-open-feed, link--close-feed and link—to-top - Remove arrow-up and arrow-down - Remove arrow-split - Remove "website" icon - Remove “error” icon - Update like & dislike button in the screening section - Remove 'bulb' svg from sprite - Remove 'hero-home-left-pixels' sprite - Remove 'hero-home-right-pixels' from sprite - Remove 'magnifying-glass' svg from sprite - Remove 'person-icon' and profile_button.html - Replace 'caret-down' and 'caret-up' icon - Remove 'side-arrow' from svg sprite - Remove 'add-user' icon, replace with 'user-plus' - Remove 'logo-desktop', 'logo-mobile' and 'logo-desktop--dark' icons - Remove 'logo-mobile-no-text' icon - Remove 'logo-mobile-dark' and 'logo-desktop--dark-alt' - Remove 'hero-standard-left-pixels' and 'hero-standard-right-pixels' - Remove 'eye' icon and replace with heroicon 'eye' - Remove 'exclamation-point' icon and replace by heroicon exlaimation-circle - Remove 'github' icon - Remove 'person-icon' and profile_button.html - Replace 'caret-down' and 'caret-up' icon - Remove 'side-arrow' from svg sprite closes #3703 depends on #3722
Vldln
pushed a commit
to equalitie/hypha
that referenced
this pull request
May 28, 2024
- Upgrade heroicons to 2.6.0, adds support for heroicons_mirco - Remove/upgrade sprite icons - Update icons in the global messages widget - Remove unused bgg-logo sprite - Update calendar icon with heroicon - Update anchor-link icon - Remove speech-bubble icon and link—-open-feed, link--close-feed and link—to-top - Remove arrow-up and arrow-down - Remove arrow-split - Remove "website" icon - Remove “error” icon - Update like & dislike button in the screening section - Remove 'bulb' svg from sprite - Remove 'hero-home-left-pixels' sprite - Remove 'hero-home-right-pixels' from sprite - Remove 'magnifying-glass' svg from sprite - Remove 'person-icon' and profile_button.html - Replace 'caret-down' and 'caret-up' icon - Remove 'side-arrow' from svg sprite - Remove 'add-user' icon, replace with 'user-plus' - Remove 'logo-desktop', 'logo-mobile' and 'logo-desktop--dark' icons - Remove 'logo-mobile-no-text' icon - Remove 'logo-mobile-dark' and 'logo-desktop--dark-alt' - Remove 'hero-standard-left-pixels' and 'hero-standard-right-pixels' - Remove 'eye' icon and replace with heroicon 'eye' - Remove 'exclamation-point' icon and replace by heroicon exlaimation-circle - Remove 'github' icon - Remove 'person-icon' and profile_button.html - Replace 'caret-down' and 'caret-up' icon - Remove 'side-arrow' from svg sprite closes HyphaApp#3703 depends on HyphaApp#3722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3703
depends on #3722