Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin 2FA disable flow #3708

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fix admin 2FA disable flow #3708

merged 1 commit into from
Jan 8, 2024

Conversation

theskumar
Copy link
Member

  • Use sudo mode instead of asking for password
  • prompt confirmation text before final disable action
  • Clean/Rename the confirmation form

closes: #3705

- Use sudo mode instead of asking for password
- prompt confirmation text before final disable action
- Clean/Rename the confirmation form

closes: #3705
@theskumar theskumar self-assigned this Jan 4, 2024
@theskumar theskumar requested review from frjo and wes-otf January 4, 2024 09:04
@theskumar theskumar added Type: Bug Bugs! Things that are broken :-/ Type: Patch Mini change, used in release drafter labels Jan 4, 2024
@frjo frjo added the Status: Needs testing Tickets that need testing/qa label Jan 5, 2024
@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa labels Jan 5, 2024
@frjo frjo merged commit 48719ed into main Jan 8, 2024
@theskumar theskumar deleted the fix/admin-2fa-disable branch January 9, 2024 12:52
wes-otf pushed a commit that referenced this pull request May 7, 2024
- Use sudo mode instead of asking for password
- prompt confirmation text before final disable action
- Clean/Rename the confirmation form

closes: #3705
wes-otf pushed a commit that referenced this pull request May 8, 2024
- Use sudo mode instead of asking for password
- prompt confirmation text before final disable action
- Clean/Rename the confirmation form

closes: #3705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Tested - approved for live ✅ Type: Bug Bugs! Things that are broken :-/ Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'password' when trying to disable another user's 2FA
4 participants