Enabled validation of determination draft saving #3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wes-otf
added
Type: Bug
frjo
approved these changes
Jan 4, 2024
wes-otf
added a commit
that referenced
this pull request
May 7, 2024
Fixes #3706 A draft determination shouldn't be able to be saved without setting an outcome, as there isn't a valid state to store it in (and if a determination is being drafted, an outcome has been reached). This enforces partial form validation when a determination draft is saved to ensure an outcome is set.
wes-otf
added a commit
that referenced
this pull request
May 8, 2024
Fixes #3706 A draft determination shouldn't be able to be saved without setting an outcome, as there isn't a valid state to store it in (and if a determination is being drafted, an outcome has been reached). This enforces partial form validation when a determination draft is saved to ensure an outcome is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3706
A draft determination shouldn't be able to be saved without setting an outcome, as there isn't a valid state to store it in (and if a determination is being drafted, an outcome has been reached). This enforces partial form validation when a determination draft is saved to ensure an outcome is set.
Test Steps
Add DeterminationDeterminationdropdown at-- No determination selected --Please select an item in the listis shown at the dropdown prompt, not allowing for a draft to be saved.