Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow project for a project's requested funding value to be a decimal #3692

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

wes-otf
Copy link
Contributor

@wes-otf wes-otf commented Dec 11, 2023

Fixes #3680. Swaps the PositiveInteger field for a DecimalField with a validator that ensures the input value is >= 0. Ensures project creation no longer generates an exception when a project's Requested Funding field has a decimal.

Copy link
Member

@theskumar theskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@frjo frjo added Type: Bug Bugs! Things that are broken :-/ Status: Needs testing Tickets that need testing/qa Type: Patch Mini change, used in release drafter labels Dec 13, 2023
@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa labels Dec 15, 2023
@wes-otf
Copy link
Contributor Author

wes-otf commented Dec 15, 2023

Tested by @Techslammer. No issues on creation.

@frjo frjo merged commit 0d99f66 into main Dec 16, 2023
@frjo frjo deleted the fix/create-project-decimal branch February 12, 2024 11:47
wes-otf added a commit that referenced this pull request May 7, 2024
…#3692)

Fixes #3680. Swaps the PositiveInteger field for a DecimalField with a
validator that ensures the input value is >= 0. Ensures project creation
no longer generates an exception when a project's `Requested Funding`
field has a decimal.
wes-otf added a commit that referenced this pull request May 8, 2024
…#3692)

Fixes #3680. Swaps the PositiveInteger field for a DecimalField with a
validator that ensures the input value is >= 0. Ensures project creation
no longer generates an exception when a project's `Requested Funding`
field has a decimal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Tested - approved for live ✅ Type: Bug Bugs! Things that are broken :-/ Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to create a project from a submission with a decimal value results in an error
3 participants