Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused pagedown css demo.css #3676

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Remove unused pagedown css demo.css #3676

merged 1 commit into from
Jan 31, 2025

Conversation

theskumar
Copy link
Member

No description provided.

@theskumar theskumar self-assigned this Dec 5, 2023
@theskumar theskumar requested a review from frjo December 5, 2023 04:13
@frjo
Copy link
Member

frjo commented Dec 5, 2023

Without this file this CSS gets loaded when the Pagedown editor is active: https://github.com/StackExchange/pagedown/blob/32c0bdb121de04e0e956ddde0391022644ff1a76/demo/browser/demo.css

@theskumar
Copy link
Member Author

Without this file this CSS gets loaded when the Pagedown editor is active: https://github.com/StackExchange/pagedown/blob/32c0bdb121de04e0e956ddde0391022644ff1a76/demo/browser/demo.css

Thanks for pointing that out, I still feel not loading the css file in the first would be better. I've updated the pagedownwidget here d913750

@frjo frjo added Type: Maintenance Type: Patch Mini change, used in release drafter labels Dec 7, 2023
@frjo frjo closed this Jul 5, 2024
@theskumar theskumar deleted the remove-pagedown-demo-css branch July 5, 2024 07:23
@frjo frjo restored the remove-pagedown-demo-css branch January 30, 2025 17:55
@frjo frjo reopened this Jan 30, 2025
@frjo frjo force-pushed the remove-pagedown-demo-css branch from d913750 to 548822e Compare January 30, 2025 18:05
@frjo frjo force-pushed the remove-pagedown-demo-css branch from 548822e to f88a019 Compare January 30, 2025 18:09
@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jan 30, 2025
@frjo frjo merged commit 6add0ee into main Jan 31, 2025
7 checks passed
@frjo frjo deleted the remove-pagedown-demo-css branch March 11, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants