Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and enhancements to project invoice detail page #3666

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

theskumar
Copy link
Member

@theskumar theskumar commented Nov 26, 2023

  1. Fix link to "view project page"
  2. Add bg-light-grey as there are a log of white cards
  3. Fix margin top on the top-most card.
  4. Do not show supporting documents section if they are not present

Before

Screenshot 2023-11-26 at 6  39 02@2x

After

Screenshot 2023-11-26 at 6  36 37@2x

- Fix link to "view project page"
- Add bg-light-grey as there are a log of white cards
- Fix margin top on the top-most card.
- Do not show supporting documents section if they are not present
@theskumar theskumar self-assigned this Nov 26, 2023
@theskumar theskumar requested review from frjo and wes-otf November 26, 2023 06:36
@theskumar theskumar changed the title Fix and enchancements to project invoice detail page Fixes and enhancements to project invoice detail page Nov 26, 2023
@@ -202,7 +202,7 @@
}

.card:first-child {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just remove this?
.card is used at other places as well but I don't think its first child top margin makes sense anywhere.

@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter Status: Needs testing Tickets that need testing/qa labels Nov 28, 2023
@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa labels Dec 1, 2023
@frjo frjo merged commit bb56b2e into main Dec 1, 2023
@theskumar theskumar deleted the fix/invoice-detail-page branch December 5, 2023 04:05
wes-otf pushed a commit that referenced this pull request May 7, 2024
1. Fix link to "view project page"
2. Add bg-light-grey as there are a log of white cards
3. Fix margin top on the top-most card.
4. Do not show supporting documents section if they are not present
wes-otf pushed a commit that referenced this pull request May 8, 2024
1. Fix link to "view project page"
2. Add bg-light-grey as there are a log of white cards
3. Fix margin top on the top-most card.
4. Do not show supporting documents section if they are not present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Tested - approved for live ✅ Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants