Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test duration file and locale files. Also lock Faker to v19.x. #3657

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

frjo
Copy link
Member

@frjo frjo commented Nov 14, 2023

Faker v20.x makes a number of test not work. Faker is a dependency of factory_boy.

An update to factory_boy might fix it or we need to update our tests. This fix works in the meantime.

@frjo frjo added Type: Maintenance Type: Patch Mini change, used in release drafter labels Nov 14, 2023
@frjo frjo changed the title Update test duration file and locale files. Update test duration file and locale files. Also lock Faker to v19.x. Nov 14, 2023
@frjo frjo merged commit 6cdbc07 into main Nov 14, 2023
theskumar added a commit that referenced this pull request Nov 20, 2023
…login-signup

* origin/main:
  Fix visibility of last item of status bar on submission detail page (#3656)
  Update test duration file and locale files. Also lock Faker to v19.x.  (#3657)
@frjo frjo deleted the maintenance/update_locale_test_durations branch February 12, 2024 11:46
wes-otf pushed a commit that referenced this pull request May 7, 2024
…#3657)

Faker v20.x makes a number of test not work. Faker is a dependency of
factory_boy.

An update to factory_boy might fix it or we need to update our tests.
This fix works in the meantime.
wes-otf pushed a commit that referenced this pull request May 8, 2024
…#3657)

Faker v20.x makes a number of test not work. Faker is a dependency of
factory_boy.

An update to factory_boy might fix it or we need to update our tests.
This fix works in the meantime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant