Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grey background to PAF detail page #3651

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Add grey background to PAF detail page #3651

merged 2 commits into from
Nov 23, 2023

Conversation

sandeepsajan0
Copy link
Member

@sandeepsajan0 sandeepsajan0 commented Nov 8, 2023 •
edited
Loading

Fixes #3650
The PAF page contains multiple cards/boxes, so we want its background as grey to enhance the visibility of those boxes.

How it looks right now:
image

With this PR:
image

theskumar
theskumar requested changes Nov 9, 2023
View reviewed changes
Copy link
Member

@theskumar theskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the body_class instead?

{% block body_class %}bg-light-grey{% endblock %}

@sandeepsajan0 sandeepsajan0 force-pushed the enhancement/gh-3650-grey-bg-paf branch from 8623ea9 to e723ecb Compare November 15, 2023 12:25
@frjo
Copy link
Member

frjo commented Nov 20, 2023

@theskumar Can you approve the changes if they look good?

theskumar
theskumar approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@theskumar theskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better!

@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter labels Nov 23, 2023
@frjo frjo merged commit 475e3e6 into main Nov 23, 2023
@wes-otf wes-otf mentioned this pull request Dec 15, 2023
Merged
@frjo frjo deleted the enhancement/gh-3650-grey-bg-paf branch February 12, 2024 11:47
wes-otf pushed a commit that referenced this pull request May 7, 2024
@sandeepsajan0 @wes-otf
Add grey background to PAF detail page (#3651)
3d93930 
Fixes #3650 
The PAF page contains multiple cards/boxes, so we want its background as
grey to enhance the visibility of those boxes.
wes-otf pushed a commit that referenced this pull request May 8, 2024
@sandeepsajan0 @wes-otf
Add grey background to PAF detail page (#3651)
2de8e9a 
Fixes #3650 
The PAF page contains multiple cards/boxes, so we want its background as
grey to enhance the visibility of those boxes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theskumar theskumar theskumar approved these changes

Assignees
No one assigned
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the grey background to the PAF page
3 participants
@sandeepsajan0 @frjo @theskumar