Add "PAFs for review" table for paf approvers #3645
Conversation
sandeepsajan0
changed the title
We decided on November 7 that submit_date is enough and the date_requested is when staff submits the PAF for approval. |
|
@frjo It is also ready for testing. |
frjo
added
Type: Enhancement
|
The table columns are clickable but it doesn't do any sorting. Also can we make only the columns with arrows clickable but not the others? are we also planning to add also because the arrow head looks a bit misaligned, can we use the double arrowhead icon instead? or try to align that one? |
|
@abhiXII thanks for the feedback.
I think we should show all the |
sandeepsajan0
force-pushed
the
feature/paf-review-dashboard-table
branch
from
3b86b44 to
4d25eef
Compare
|
I have fixed the sorting issue, only |
|
This looked good in test, I only saw a small issue where making the screen width < 1024px caused the table to act a little weird. I'm not sure how concerned we are about mobile/tablet views for the staff dashboards and perspectives though so this might not matter all that much and can be put to live.
|
|
@wes-otf Thanks for bringing that up. I also see this issue with other projects and invoice related tables. I'll fix it for |
|
Updated table view only for tablets or smaller size screens. |
|
Latest version on test now. |
Fixes #3535 Right now, we have two tables on the approvers dashboard "PAF waiting for approval" and "PAF waiting for assignee" but as per the latest design we want a new table "PAFs for review" that contains data from both of the above tables and list it in a simple manner. In this PR we are just adding that new table but not removing the older ones, once we are done with the new table testing and are ready to have it then we can remove the older ones. The date requested column is kind of not clear yet. We have multiple dates, one of them is the "Submitted date" which is when a lead/staff submits the PAF for the first time. Another one is "Updated date" which is when staff submits or this approval(not paf) is updated even for change approver/assignee(right now I have used this one). But I think we might need to maintain one more date as the "date requested" for every approval, which might be different from both of the above dates in sequential workflow(ex: the second approval date_requested will be set as the first approval approved_date) while it will be same as submit_date for parallel workflow. What do you all think, is the submit_date enough, or should we have date_requested as another as explained above? **Update** We decided to use submit_date as date_requested. Removing the old tables as the new table contains both old tables' data.
Fixes #3535 Right now, we have two tables on the approvers dashboard "PAF waiting for approval" and "PAF waiting for assignee" but as per the latest design we want a new table "PAFs for review" that contains data from both of the above tables and list it in a simple manner. In this PR we are just adding that new table but not removing the older ones, once we are done with the new table testing and are ready to have it then we can remove the older ones. The date requested column is kind of not clear yet. We have multiple dates, one of them is the "Submitted date" which is when a lead/staff submits the PAF for the first time. Another one is "Updated date" which is when staff submits or this approval(not paf) is updated even for change approver/assignee(right now I have used this one). But I think we might need to maintain one more date as the "date requested" for every approval, which might be different from both of the above dates in sequential workflow(ex: the second approval date_requested will be set as the first approval approved_date) while it will be same as submit_date for parallel workflow. What do you all think, is the submit_date enough, or should we have date_requested as another as explained above? **Update** We decided to use submit_date as date_requested. Removing the old tables as the new table contains both old tables' data.
Fixes #3535
Right now, we have two tables on the approvers dashboard "PAF waiting for approval" and "PAF waiting for assignee" but as per the latest design we want a new table "PAFs for review" that contains data from both of the above tables and list it in a simple manner.
In this PR we are just adding that new table but not removing the older ones, once we are done with the new table testing and are ready to have it then we can remove the older ones.
The date requested column is kind of not clear yet.
We have multiple dates, one of them is the "Submitted date" which is when a lead/staff submits the PAF for the first time. Another one is "Updated date" which is when staff submits or this approval(not paf) is updated even for change approver/assignee(right now I have used this one).
But I think we might need to maintain one more date as the "date requested" for every approval, which might be different from both of the above dates in sequential workflow(ex: the second approval date_requested will be set as the first approval approved_date) while it will be same as submit_date for parallel workflow.
What do you all think, is the submit_date enough, or should we have date_requested as another as explained above?
Update
We decided to use submit_date as date_requested.
Removing the old tables as the new table contains both old tables' data.