Added descriptions to group selections in Wagtail admin

[wes-otf]

Fixes #3541.

This PR adds descriptive help text to the Wagtail admin edit/create user "Groups" prompt. This was done by creating custom Wagtail forms and overwriting the existing group field, along with adding another field to the groups.py.

The definitions provided by @fourthletter were shortened just a bit for the sake of appearance. If anyone believes they got too truncated I'm fine with updating them.

Screenshots

Cheers!

[wes-otf]

The CI gods did not favor me today. Couldn't get the test to fail locally but will continue work tomorrow.

[fourthletter]

@wes-otf - I forgot to add definitions for staff admin and community reviewer

Staff Admin view and edit all submissions, submit reviews, send determinations, and set up applications. Can disable 2FA, archive submissions, and other components not accessible to other roles.

Community Reviewer is an applicant with access to other applications for the Request with community review (peer review) workflow.

[frjo]

@wes-otf Try running:

pytest --ds=hypha.settings.test --store-durations

and then commit the updated .test_durations file to the PR. This sometimes resolves these kind of issues.

[frjo]

Please also test this on top of the Django 4 and Wagtail 5 PRs. Or we just wait until they have been merged it.

[frjo]

Staff Admin view and edit all submissions, submit reviews, send determinations, and set up applications. Can disable 2FA, archive submissions, and other components not accessible to other roles.

This is not correct. Most of these are reliant on permission settings in Wagtail. These are completely up to each organisation to set to whatever they like.

The only thing I know for sure are linked to "Staf admin" is "View message log".

Important also to point out that "Staff admin" always should be used together with "Staff".

[wes-otf]

@frjo So should abilities given by wagtail permissions should not be included in the description? Would this effect any of the given descriptions?

These are completely up to each organisation to set to whatever they like.

With the addition of translations in groups.py, wouldn't different orgs be able to customize what that description is?

[wes-otf]

Just tested with both the Wagtail 5 branch & Django 4 branches, both worked totally fine. Only thing I saw is that our edit/create user templates use the Wagtail shared template field_as_li.html a few times and Wagtail has said this will be removed in a future release. I could swap these out proactively if that would be worthwhile.

Otherwise this should be all set once confirmation is given on those final group descriptions! Tests looked to be failing because of a migration that wasn't made so that is also included here.

[wes-otf]

The latest updates that are ready for review:

[frjo]

@wes-otf We merge in some other things so there are a merge conflict here.

[frjo]

Would be good to implement this on the "/admin/groups/" view as well.

[wes-otf]

Roger that, adding that in now.

[wes-otf]

This should be all set! Here's what the new Wagtail admin group list looks like:

[wes-otf]

Alright I believe it's actually set now. It looks like the changes in #3664 were overriding the wagtail admin user creation view so I took a stab at making it more programmatic with less code duplication. Saving users still works with the consent checkbox enabled.

@frjo @theskumar let me know if you guys have any more thoughts otherwise it's ready for test

[frjo]

Needs a new rebase to solve merge conflicts.

After that we put on test just to confirm and then I think it is ready to go.

[wes-otf]

All set here