Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invoices rows to applicant dashboard with different kind of invoice statuses #3600

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

sandeepsajan0
Copy link
Member

No current version(newly added table to applicant dashboard).

Design:
image

Updated version:
image

@sandeepsajan0 sandeepsajan0 marked this pull request as ready for review October 13, 2023 12:28
@sandeepsajan0 sandeepsajan0 marked this pull request as draft October 13, 2023 12:29
@sandeepsajan0 sandeepsajan0 force-pushed the enhancement/active-invoice branch from 1518121 to 6b8cab0 Compare November 8, 2023 11:25
@sandeepsajan0 sandeepsajan0 marked this pull request as ready for review November 8, 2023 11:29
@sandeepsajan0
Copy link
Member Author

@frjo It is ready for testing.

@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Status: Needs testing Tickets that need testing/qa Type: Patch Mini change, used in release drafter Type: Feature This is something new (not an enhancement of an existing thing). and removed Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). labels Nov 9, 2023
@abhiXII
Copy link

abhiXII commented Nov 16, 2023

Here, my feedback would be just to add the white background for rows and remove underline from the invoice numbers.
image

Q: will we show all the invoices here or top 5 or something with a button to View all invoices? Maybe we'll show all where action is required right so the ones with - pending, change requested or failed right?

also are we using the font roboto in designs? somehow the font for $1000 dollar values doesn't match with what I see in design. am I missing something? or maybe it's always been like that and im just noticing it now?

@sandeepsajan0
Copy link
Member Author

@abhiXII thanks for the feedback.

just to add the white background and remove underline from the invoice numbers

The row background is already white it is the body background that is not grey yet that's why its color doesn't look different. We already have a PR for that(#3602), it will look similar to the design after that PR. I think underlining was in the design initially? I checked it is not there now so I'll remove it.

will we show all the invoices here or top 5 or something with a button to View all invoices?

For now, we are showing all active invoices here because we don't have a separate table for that yet(new navigation and tables). And I think it is fine for now. As soon as we will work on navigation and tables for applicants we can add a View all invoice button there with only the five latest invoices.

also are we using the font roboto in designs? somehow the font for $1000 dollar values doesn't match with what I see in design. am I missing something? or maybe it's always been like that and im just noticing it now?

Not sure but I haven't updated the font, I think it is the same everywhere. I just updated its size and type(like light/bold).

@frjo frjo added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa labels Nov 20, 2023
@frjo frjo merged commit d7b72ed into main Nov 20, 2023
@theskumar theskumar deleted the enhancement/active-invoice branch November 21, 2023 08:26
wes-otf pushed a commit that referenced this pull request May 7, 2024
…ce statuses (#3600)

No current version(newly added table to applicant dashboard).
wes-otf pushed a commit that referenced this pull request May 8, 2024
…ce statuses (#3600)

No current version(newly added table to applicant dashboard).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Tested - approved for live ✅ Type: Feature This is something new (not an enhancement of an existing thing). Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants