Delete submission creation event(NEW SUBMISSION) on submission deletion #3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frjo
approved these changes
Jun 18, 2023
frjo
added
Type: Enhancement
|
I agree with your point about #3441 |
|
@frjo Can we put this PR to the test site? Or it needs rebasing? |
|
Deploying to test now. |
sandeepsajan0
force-pushed
the
fix/gh-3442-delete-user
branch
from
4b3acf4 to
41114c8
Compare
|
@frjo I found that I missed deleting these events for batch delete action. I have fixed the PR. Can you please put its latest version to the test site? |
|
@fourthletter It is ready for your testing. You can test this with a new user or with a user whose data hasn't been deleted yet. |
fourthletter
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
frjo
pushed a commit
that referenced
this pull request
Nov 23, 2023
…3658) Closes #3442. This small migration addition compliments #3445 as it will remove any previous `NEW_SUBMISSION` events that belong to submissions that no longer exist. This will allow for the removal of applicants that don't have any active submission, but can't be deleted due to the `The object you are trying to delete is used somewhere...` error. Cheers!
wes-otf
added a commit
that referenced
this pull request
May 7, 2024
…3658) Closes #3442. This small migration addition compliments #3445 as it will remove any previous `NEW_SUBMISSION` events that belong to submissions that no longer exist. This will allow for the removal of applicants that don't have any active submission, but can't be deleted due to the `The object you are trying to delete is used somewhere...` error. Cheers!
wes-otf
added a commit
that referenced
this pull request
May 8, 2024
…3658) Closes #3442. This small migration addition compliments #3445 as it will remove any previous `NEW_SUBMISSION` events that belong to submissions that no longer exist. This will allow for the removal of applicants that don't have any active submission, but can't be deleted due to the `The object you are trying to delete is used somewhere...` error. Cheers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible Fix of #3442
On submission deletion, all other activities, determination, and other things are getting removed but as this
NEW SUBMISSIONevent is not directly connected to submission so not getting removed. It is creating issues at the time of user deletion even after submission deletion.I was also thinking to show the model name, and object name in error itself but user deletion only seems to be dependent on
ActivitiesandEvents(user can also be deleted only by removing Activities and events not submissions related to them), and even if we show staff the event or activities ids I don't think staff can easily delete those anyhow via UI. I think we need to decide a better way to delete a user, maybe issue #3441 help us?