Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks that person_type and news_type queries are numerical and i… #1148

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

frjo
Copy link
Member

@frjo frjo commented Apr 3, 2019

…gnore otherwise. Avoids a lot of invalid literal for int errors.

See "ValueError" in Sentry.

…gnore otherwise. Avoids a lot of invalid literal for int erros.
@frjo frjo requested a review from Parbhat April 3, 2019 12:42
Copy link
Contributor

@Parbhat Parbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@frjo frjo force-pushed the fix/invalid-literal-for-int-people-and-news branch from 3a96e3e to 470cf3a Compare April 3, 2019 18:44
@frjo frjo force-pushed the fix/invalid-literal-for-int-people-and-news branch from 470cf3a to 5d4880c Compare April 3, 2019 18:53
@frjo frjo added the RTBC label Apr 3, 2019
@frjo frjo merged commit ea6d376 into master Apr 4, 2019
@frjo frjo deleted the fix/invalid-literal-for-int-people-and-news branch April 25, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants