Delete Submission permission, view and link #1145
Conversation
| request=request, | ||
| submission=submission, | ||
| ) | ||
| response = super().delete(request, *args, **kwargs) |
There was a problem hiding this comment.
Ideally, the message should be sent after deletion of submission. But the messaging system requires Event model object which has a non-null foreign key to submission. We have to make some changes in the messaging system to make event optional. Suggestions?
There was a problem hiding this comment.
I do not think will be a problem. In worst case senario the submission is not deleted but OTF staff get a notice that it has been deleted. Nice work!
There was a problem hiding this comment.
yeah, it should not be an issue.
| request=request, | ||
| submission=submission, | ||
| ) | ||
| response = super().delete(request, *args, **kwargs) |
There was a problem hiding this comment.
I do not think will be a problem. In worst case senario the submission is not deleted but OTF staff get a notice that it has been deleted. Nice work!
|
@frjo Thanks for the review and adding missing migration. |
frjo
force-pushed
the
feature/728-delete-submissions
branch
from
6dca87f to
7db7414
Compare
Groups can be given delete submission permission from Wagtail admin.
Closes #728