Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle not getting valid input for an ID in query params #4358

Closed
wes-otf opened this issue Jan 23, 2025 · 2 comments
Closed

Gracefully handle not getting valid input for an ID in query params #4358

wes-otf opened this issue Jan 23, 2025 · 2 comments
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature).

Comments

@wes-otf
Copy link
Contributor

wes-otf commented Jan 23, 2025

When an invalid id is provided as a query param for the all submissions view (ie. ?rounds=aa&fund=fghj), the server throws an error rather than notifying the user/ignoring the invalid input

@wes-otf wes-otf added the Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). label Jan 23, 2025
@wes-otf
Copy link
Contributor Author

wes-otf commented Jan 23, 2025

very much an edge case, just came up a few times when staff were trying to work around #4357

frjo pushed a commit that referenced this issue Jan 31, 2025
Fixes #4357 & #4358. Multiple small fixes to the all submissions table,
including:

- Allowing for the selection of multiple rounds, leads, and funds while
filtering
- Updated display tags for filters to reflect multiple selections
- Added template tag to get display names of users in filter tag display
(leads + reviewers)
- Added `scroll-auto` to remove the scroll bar gap on some of the
submenus
- Caps normalizations
- Handling of non-int values in query params that use int ids
- Added more translatable strings
@wes-otf
Copy link
Contributor Author

wes-otf commented Feb 10, 2025

Closed by #4360

@wes-otf wes-otf closed this as completed Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature).
Projects
None yet
Development

No branches or pull requests

1 participant