Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom dashboard and submission detail views for reviewers, partners and community reviewers #1147

Closed
frjo opened this issue Apr 3, 2019 · 2 comments · Fixed by #1153
Closed

Custom dashboard and submission detail views for reviewers, partners and community reviewers #1147

frjo opened this issue Apr 3, 2019 · 2 comments · Fixed by #1153
Assignees
@Parbhat
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature).
Milestone
2019-Q2

Comments

@frjo
Copy link
Member

frjo commented Apr 3, 2019 •
edited
Loading

Dashboard

New custom dashboards for Partners and Community reviewers. Additions to reviewers dashboard.

Reviewers:

  • Mainly write reviews and that part of the dashboard works well.
  • They also can send in their own submissions and if they do a new section should display on their dashboard similar to what applicants see.

Partners:

  • Should see the submission they have been added to as partners. They can both review and edit these submissions.
  • Should see any reviews they write just like reviewers.
  • Should see their own submissions if they send in any.

Community reviewers:

  • Mainly write their own submissions as applicants.
  • Should also see a list of any submissions that are in a COMMUNITY_REVIEW_PHASES state. These they can review.
  • Should see any reviews they write just like reviewers.

Submission detail view

New custom submission detail views for Partners and Community reviewers.

Partners:

  • Everything like applicants
  • See their own reviews and reviews set to be public.

Community reviewers:

  • Everything like applicants
  • See their own reviews and reviews set to be open to all reviewers.
@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). apply labels Apr 3, 2019
@frjo frjo added this to the 2019-Q2 milestone Apr 3, 2019
@frjo frjo self-assigned this Apr 3, 2019
@frjo frjo mentioned this issue Apr 8, 2019
Merged
@frjo frjo assigned Parbhat and unassigned frjo Apr 17, 2019
@frjo frjo changed the title Custom dashboard for partners and community reviewers Custom dashboard and submission detail views for reviewers, partners and community reviewers Apr 17, 2019
Parbhat added a commit that referenced this issue Apr 19, 2019
@Parbhat
GH-1147: Show reviewer's submissions in dashboard
b936f8d
Parbhat added a commit that referenced this issue Apr 19, 2019
@Parbhat
GH-1147: Dashboard view for partners
181926a
Parbhat added a commit that referenced this issue Apr 19, 2019
@Parbhat
GH-1147: Dashboard view for community reviewers
8273314
Parbhat added a commit that referenced this issue Apr 22, 2019
@Parbhat
GH-1147: Partner submission list show submissions which user can revi…
fa407d4 
…ew, edit. Minor refactoring.
Parbhat added a commit that referenced this issue Apr 22, 2019
@Parbhat
GH-1147: basic template partner and community detail view and edit vi…
93d8194 
…ew for partner
@Parbhat
Copy link
Contributor

Parbhat commented Apr 22, 2019 •
edited
Loading

In Submission detail view for partners and Community reviewers:

See their own reviews and reviews set to be public.

Are there any public reviews? From the current state, it does not seem we have any public reviews.

@frjo
Copy link
Member Author

frjo commented Apr 22, 2019

Bad wording by me. Have updated the text now.

There is a new "visibility" field that can be added to review forms, by default set to "private". It can also be set to "reviewers".

  • Private: Only visible to the review author and to staff. (This is how it has worked earlier.)
  • Reviewers: Visible to all reviewers and to staff.

Parbhat added a commit that referenced this issue Apr 23, 2019
@Parbhat
GH-1147: Partner can edit whenever applicant can in addition to ac re…
549be95 
…view phase
Parbhat added a commit that referenced this issue Apr 23, 2019
@Parbhat
GH-1147: Partner can view submission detail view only if has access a…
202d1a8 
…nd status of submission in edit/review phase
Parbhat added a commit that referenced this issue Apr 23, 2019
@Parbhat
GH-1147: Remove additional check as partner can see applications like…
6560863 
… an applicant
Parbhat added a commit that referenced this issue Apr 23, 2019
@Parbhat
GH-1147: Show your active application section to reviewers only if exist
d4c152e
Parbhat added a commit that referenced this issue Apr 23, 2019
@Parbhat
GH-1147: Community reviewer can not review his own submissions in com…
1dbfdde 
…munity review stage
Parbhat added a commit that referenced this issue Apr 23, 2019
@Parbhat
GH-1147: title for partner submissions
3f3ad1f
Parbhat added a commit that referenced this issue Apr 23, 2019
@Parbhat
GH-1147: Allow partner to edit own application
4c60a5c
Parbhat added a commit that referenced this issue Apr 23, 2019
@Parbhat
GH-1147: display status bar for partners
ffc1c91
Parbhat added a commit that referenced this issue Apr 24, 2019
@Parbhat
GH-1147: determination views for partners and community reviewers
5c2baeb
Parbhat added a commit that referenced this issue Apr 24, 2019
@Parbhat
GH-1147: Allow partners, community reviewers to access reviews in rev…
6bceaa0 
…iewers visibility
Parbhat added a commit that referenced this issue Apr 24, 2019
@Parbhat
GH-1147:Revert to old behaviour where reviewers can access any submis…
042c32a 
…sion
Parbhat added a commit that referenced this issue Apr 25, 2019
@Parbhat
GH-1147: Use UserPassesTestMixin in ReviewDisplay
7031da7
Parbhat added a commit that referenced this issue Apr 25, 2019
@Parbhat
GH-1147: Add permissions for ReviewOpinionFormView
9e2af53
@frjo frjo mentioned this issue May 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Parbhat Parbhat

Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature).
Projects
None yet
Milestone
2019-Q2
Development

Successfully merging a pull request may close this issue.

Add seperate dashboard and submissiondetail views for partner and com… HyphaApp/hypha
2 participants
@frjo @Parbhat