Fix some nits from previous commit #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoger
commented
Oct 11, 2020
Comment on lines
+84
to
+99
| go func() { | ||
| for i := 0; i < N; i++ { | ||
| prop, err := CreateProposal( | ||
| crypto, | ||
| config.Channel, | ||
| config.Chaincode, | ||
| config.Version, | ||
| config.Args..., | ||
| ) | ||
| if err != nil { | ||
| errorCh <- errors.Wrapf(err, "error creating proposal") | ||
| return | ||
| } | ||
| raw <- &Elements{Proposal: prop} | ||
| } | ||
| }() |
There was a problem hiding this comment.
this is now put into a go routine
There was a problem hiding this comment.
is it necessary to do so, I mean put into a go routine ?
or say a new struct with N, crypto, config, errorCh to make it similar with observer?
guoger
force-pushed
the
nit-fixing
branch
2 times, most recently
from
03490ae to
f3afcdc
Compare
- move process out of main - correct some grammar in log msg Signed-off-by: Jay Guo <[email protected]>
Closed
SamYuan1990
reviewed
Oct 12, 2020
Comment on lines
+84
to
+99
| go func() { | ||
| for i := 0; i < N; i++ { | ||
| prop, err := CreateProposal( | ||
| crypto, | ||
| config.Channel, | ||
| config.Chaincode, | ||
| config.Version, | ||
| config.Args..., | ||
| ) | ||
| if err != nil { | ||
| errorCh <- errors.Wrapf(err, "error creating proposal") | ||
| return | ||
| } | ||
| raw <- &Elements{Proposal: prop} | ||
| } | ||
| }() |
There was a problem hiding this comment.
is it necessary to do so, I mean put into a go routine ?
or say a new struct with N, crypto, config, errorCh to make it similar with observer?
guoger
added a commit
that referenced
this pull request
Nov 6, 2020
- move process out of main - correct some grammar in log msg Signed-off-by: Jay Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jay Guo [email protected]