Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to TWGC #198

Merged
merged 1 commit into from
Aug 16, 2021
Merged

migrate to TWGC #198

merged 1 commit into from
Aug 16, 2021

Conversation

davidkhala
Copy link
Member

migrate from domain guoger to TWGC
Signed-off-by: DavidLiu [email protected]

@SamYuan1990
Copy link
Member

seems missing for docker image push and where is the docker repo url?

@guoger
Copy link
Member

guoger commented Aug 11, 2021

seems missing for docker image push and where is the docker repo url?

PR looks good to me. Currently my dockerhub is configured with a CD pipeline that watches this repo and automatically build image. It seems pretty robust and simple. Not sure if the same could be done with new docker registry?

@SamYuan1990
Copy link
Member

seems missing for docker image push and where is the docker repo url?

PR looks good to me. Currently my dockerhub is configured with a CD pipeline that watches this repo and automatically build image. It seems pretty robust and simple. Not sure if the same could be done with new docker registry?

yep... 1st of all, I want to know how to access TWGC docker repo. then to see if further changes need to be done in this pr as azp pipeline part, making merge into master/main trigger a latest image build. etc.

@davidkhala
Copy link
Member Author

@SamYuan1990
image
This is where you can find the published package.
ghcr.io/hyperledger-twgc/tape is the docker repository URL.

I have not yet established a pipeline to continuous-publish. But something I wonder is according to Github policy, maintainer of this repository also have right to publish docker image to organization level.

@davidkhala
Copy link
Member Author

CD

I believe it is easier to use Github Action to do so. I would have a try.

@davidkhala
Copy link
Member Author

davidkhala commented Aug 12, 2021

image
我猜用这个credential应该够了,回头试试
参考文档: https://docs.github.com/en/actions/guides/publishing-docker-images#publishing-images-to-github-packages

@davidkhala davidkhala force-pushed the migrate branch 2 times, most recently from 486a9b0 to 55df8e6 Compare August 12, 2021 10:20
@SamYuan1990
Copy link
Member

@SamYuan1990
image
This is where you can find the published package.
ghcr.io/hyperledger-twgc/tape is the docker repository URL.

I have not yet established a pipeline to continuous-publish. But something I wonder is according to Github policy, maintainer of this repository also have right to publish docker image to organization level.

I can't find it. pls help with my permission.

Copy link
Member

@SamYuan1990 SamYuan1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or @davidkhala you want to have another commit for alpha and release branch?


on:
push:
branches: ['master']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add alpha & v.*(release branch) please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alpha或者release branch发布出来的docker image tag应该怎么打?打成...tape:alpha 以及tape:1.1.1这样么?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tape:alpha 以及tape:1.1.1

@davidkhala
Copy link
Member Author

@SamYuan1990
image
This is where you can find the published package.
ghcr.io/hyperledger-twgc/tape is the docker repository URL.
I have not yet established a pipeline to continuous-publish. But something I wonder is according to Github policy, maintainer of this repository also have right to publish docker image to organization level.

I can't find it. pls help with my permission.

这个不需要权限的,已经设为全网公开的,是docker pull出的问题还是网页上看不到了?

@SamYuan1990
Copy link
Member

@SamYuan1990
image
This is where you can find the published package.
ghcr.io/hyperledger-twgc/tape is the docker repository URL.
I have not yet established a pipeline to continuous-publish. But something I wonder is according to Github policy, maintainer of this repository also have right to publish docker image to organization level.

I can't find it. pls help with my permission.

这个不需要权限的,已经设为全网公开的,是docker pull出的问题还是网页上看不到了?

yuanyi@192 ~ % docker pull ghcr.io/hyperledger-twgc/tape
Using default tag: latest
latest: Pulling from hyperledger-twgc/tape
29291e31a76a: Already exists 
f10fb7ea8362: Pull complete 
0b219d765d96: Pull complete 
Digest: sha256:c859af8ce24cbd94e58ba20b2a5ec58b7a644bd58735f8b837845ddf72d00f37
Status: Downloaded newer image for ghcr.io/hyperledger-twgc/tape:latest
ghcr.io/hyperledger-twgc/tape:latest

@davidkhala
Copy link
Member Author

davidkhala commented Aug 12, 2021

现在这个改法出来的效果是
如果push to master branch,会出tape:master, 而不是tape:latest
如果push 一个tag如v1.3.2,则会同时出tape:latest和tape:v1.3.2

转化关系见https://github.com/docker/metadata-action#basic 锚点下方的语法关系表

@davidkhala davidkhala requested a review from SamYuan1990 August 13, 2021 01:09
@SamYuan1990
Copy link
Member

SamYuan1990 commented Aug 13, 2021

现在这个改法出来的效果是
如果push to master branch,会出tape:master, 而不是tape:latest
如果push 一个tag如v1.3.2,则会同时出tape:latest和tape:v1.3.2

转化关系见https://github.com/docker/metadata-action#basic 锚点下方的语法关系表

我们试试 这个? https://github.com/docker/metadata-action#typeedge

或者 这个 https://github.com/docker/metadata-action#latest-tag

我觉得不能随意调整tag的话,对于我们有些难受了。
实际上我们通过latest发布main/master上的最新代码,通过alpha来发布一些最新改动,通过v.*的tag来做发布版本。

@davidkhala
Copy link
Member Author

davidkhala commented Aug 13, 2021

现在这个改法出来的效果是
如果push to master branch,会出tape:master, 而不是tape:latest
如果push 一个tag如v1.3.2,则会同时出tape:latest和tape:v1.3.2
转化关系见https://github.com/docker/metadata-action#basic 锚点下方的语法关系表

我们试试 这个? https://github.com/docker/metadata-action#typeedge

或者 这个 https://github.com/docker/metadata-action#latest-tag

我觉得不能随意调整tag的话,对于我们有些难受了。
实际上我们通过latest发布main/master上的最新代码,通过alpha来发布一些最新改动,通过v.*的tag来做发布版本。

我对你希望的情况,有如下的理解对么?

  • 对v.*的git tag的发布是OK的
  • master发latest, alpha branch 发edge

@SamYuan1990
Copy link
Member

  • master发latest, alpha branch 发edge

是的。如果能做到这样是最好的。

Signed-off-by: DavidLiu <[email protected]>
@davidkhala
Copy link
Member Author

  • master发latest, alpha branch 发edge

是的。如果能做到这样是最好的。

现在这个版本应该能做到这个效果,不过要merge之后才能看到效果

@SamYuan1990 SamYuan1990 merged commit c3a43b5 into master Aug 16, 2021
@SamYuan1990 SamYuan1990 deleted the migrate branch August 16, 2021 10:28
davidkhala pushed a commit that referenced this pull request Aug 16, 2021
Signed-off-by: DavidLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants