Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Test #151

Merged
merged 2 commits into from
Apr 25, 2021
Merged

Enhance Test #151

merged 2 commits into from
Apr 25, 2021

Conversation

SamYuan1990
Copy link
Member

@SamYuan1990 SamYuan1990 commented Feb 10, 2021 •
edited
Loading

  • Observer, with test case
  • block collector, with new test case
  • nit fixing

Signed-off-by: SamYuan1990 [email protected]

guoger
guoger reviewed Feb 17, 2021
View reviewed changes
e2e/mock/orderer.go Outdated Show resolved Hide resolved
@SamYuan1990 SamYuan1990 force-pushed the 149 branch 3 times, most recently from 270ba07 to 7f464e0 Compare February 23, 2021 11:50
@SamYuan1990 SamYuan1990 marked this pull request as draft February 26, 2021 10:01
@SamYuan1990 SamYuan1990 requested a review from wuxuer February 26, 2021 10:01
@SamYuan1990 SamYuan1990 marked this pull request as ready for review February 26, 2021 15:03
wuxuer
wuxuer reviewed Mar 2, 2021
View reviewed changes
pkg/infra/observer.go Outdated Show resolved Hide resolved
guoger
guoger requested changes Mar 4, 2021
View reviewed changes
Copy link
Member

@guoger guoger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. instead of coordinating observer go routines with awkward sync primitives, we could simply change collector to collect final states. observer just exits on signal
  2. newly added test still does not cover this bug

guoger
guoger requested changes Mar 5, 2021
View reviewed changes
e2e/mock/peer.go Outdated Show resolved Hide resolved
e2e/mock/peer.go Outdated Show resolved Hide resolved
pkg/infra/block_collector.go Outdated Show resolved Hide resolved
pkg/infra/block_collector.go Outdated Show resolved Hide resolved
pkg/infra/observer.go Outdated Show resolved Hide resolved
pkg/infra/observer.go Outdated Show resolved Hide resolved
pkg/infra/block_collector.go Outdated Show resolved Hide resolved
pkg/infra/block_collector.go Outdated Show resolved Hide resolved
@SamYuan1990 SamYuan1990 marked this pull request as draft March 5, 2021 14:33
@SamYuan1990 SamYuan1990 marked this pull request as ready for review March 29, 2021 08:45
guoger
guoger requested changes Apr 6, 2021
View reviewed changes
Copy link
Member

@guoger guoger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm under impression that you are trying to solve #165 and #149 at the same time? could you split this into separate PR so we could focus on one thing at a time.

e2e/mock/peer.go Outdated Show resolved Hide resolved
e2e/mock/orderer.go Outdated Show resolved Hide resolved
pkg/infra/block_collector.go Outdated Show resolved Hide resolved
@SamYuan1990 SamYuan1990 marked this pull request as draft April 10, 2021 12:21
@SamYuan1990 SamYuan1990 force-pushed the 149 branch 3 times, most recently from 2b5716d to e1bc120 Compare April 10, 2021 14:30
@SamYuan1990 SamYuan1990 marked this pull request as ready for review April 10, 2021 14:34
@SamYuan1990 SamYuan1990 changed the title reslove #149 Enhance Test Apr 10, 2021
yiwenlong
yiwenlong reviewed Apr 11, 2021
View reviewed changes
e2e/mock/peer.go Outdated Show resolved Hide resolved
guoger
guoger requested changes Apr 19, 2021
View reviewed changes
e2e/mock/peer.go Outdated Show resolved Hide resolved
e2e/mock/server.go Outdated Show resolved Hide resolved
pkg/infra/block_collector.go Show resolved Hide resolved
pkg/infra/block_collector_test.go Show resolved Hide resolved
guoger
guoger requested changes Apr 22, 2021
View reviewed changes
pkg/infra/observer_test.go Outdated Show resolved Hide resolved
pkg/infra/observer_test.go Outdated Show resolved Hide resolved
pkg/infra/observer_test.go Outdated Show resolved Hide resolved
pkg/infra/observer_test.go Show resolved Hide resolved
pkg/infra/block_collector_test.go Outdated Show resolved Hide resolved
pkg/infra/block_collector_test.go Outdated Show resolved Hide resolved
e2e/mock/peer.go Outdated Show resolved Hide resolved
@SamYuan1990
Enhance Test
06777f1 
- Observer, with test case
- block collector, with new test case
- nit fixing

reslove Hyperledger-TWGC#149

Signed-off-by: SamYuan1990 <[email protected]>
guoger
guoger requested changes Apr 25, 2021
View reviewed changes
e2e/mock/peer.go Outdated Show resolved Hide resolved
pkg/infra/block_collector_test.go Outdated Show resolved Hide resolved
pkg/infra/block_collector_test.go Outdated Show resolved Hide resolved
@guoger
Fix nits.
c637f4e 
Signed-off-by: Jay Guo <[email protected]>
@guoger guoger enabled auto-merge (squash) April 25, 2021 15:18
@guoger guoger merged commit d965232 into Hyperledger-TWGC:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuxuer wuxuer wuxuer left review comments

@yiwenlong yiwenlong yiwenlong left review comments

@guoger guoger guoger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamYuan1990 @guoger @wuxuer @yiwenlong